-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox & Chrome crashes #67
Comments
What code are you using? |
@thijstriemstra , var player = videojs("recorded-video", {
controls: true,
loop: false,
plugins: {
record: {
maxLength: 90,
debug: true,
image: false,
audio: true,
video: {
width: { min: 640, ideal: 800, max: 1280 },
height: { min: 480, ideal: 600, max: 720 }
}
}
}
}); I use custom button for starting record: $('#record-modal .start-record').click(function(){
player.recorder.getDevice();
player.recorder.start();
}); This demo crashed too https://collab-project.github.io/videojs-record/examples/audio-video.html |
You shouldn't start the recorder right after you call
|
Now that I restarted the browser I can't reproduce it though, weird. It could be a imcompatible constraint thing as well, can you try including http://webrtc.github.io/adapter/adapter-latest.js before your scripts and see if that helps? |
Ok, when I select 'No video' for that option my Firefox browser crashes as well. May I ask why you select no video when you're trying to record both audio and video? To reproduce a user error? And how are you selecting 'no' for video on Chrome. I do not have a option to set it to no in OSX, can you make a screenshot? |
When I do the same in this example the browser doesn't crash. |
I've tried debugging the issue and it looks like it's a recordrtc problem, maybe muaz-khan/RecordRTC#117. When I downgrade recordrtc to 5.3.0 (
|
Also seeing the
|
@thijstriemstra First of all thank you for replies and help. You say:
I'm just acted as a user. They can do it, so I have to handle this behavior.
Sure, just go to chrome://settings/content#media-stream-mic and there we can disable camera or microphone screen.
It's strange, but first link doesn't work in my FF 44.0.2. Error: Unable to create MediaRecorder with options Object: TypeError: Argument 1 is not valid for any of the 2-argument overloads of MediaRecorder.
Stack trace:
startRecording@https://simpl.info/mediarecorder/js/main.js:112:21
toggleRecording@https://simpl.info/mediarecorder/js/main.js:98:5 |
I've opened a new recordrtc issue because I can also reproduce it without videojs-record so it's a recordrtc.js issue, see muaz-khan/RecordRTC#118. I agree that it's a user error that should be handled. I've tried debugging the error but couldn't fix it, let's continue the conversation on the recordrtc.js ticket because there's not much I can do in this plugin I think. |
@web-maker well looks like @muaz-khan pushed a fix for this issue, can you give the latest recordrtc a try? |
@thijstriemstra I have already tested the latest version. Looks like it works fine - no crashes now in Chrome and FF. Many thanks to you andI have already tested the latest version. Looks like it works fine - no crashes now in Chrome and FF. Many thanks to you and mauz-khan. |
Awesome! Thanks guys. |
FF (or Crome) crashed when user set permissions to use microphone and select No video for video input device. In FF was detected next message:
MediaRecorder Error error { target: MediaRecorder, isTrusted: true, name: "OutOfMemoryError", currentTarget: MediaRecorder, eventPhase: 2, bubbles: false, cancelable: false, defaultPrevented: false, timeStamp: 1460385666006891, originalTarget: MediaRecorder, explicitOriginalTarget: MediaRecorder }
Problem is actually in Chrome 48/49 and FF 44/45 versions on Windows 10 and Ubuntu 14.04. Is any quickfix for this problem?
The text was updated successfully, but these errors were encountered: