Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot Framework tests fail with Plone > 4.3.11 #759

Closed
hvelarde opened this issue Oct 19, 2017 · 4 comments · Fixed by #700
Closed

Robot Framework tests fail with Plone > 4.3.11 #759

hvelarde opened this issue Oct 19, 2017 · 4 comments · Fixed by #700
Assignees
Labels

Comments

@hvelarde
Copy link
Member

After upgrading to Plone 4.3.12 all Robot Framework tests started failing as hown in the following screenshot:

selenium-screenshot-1

as it can be seen, there's a new required field being shown in the form that normally doesn't appear; this field came from a XML schema like this:

<field name="cover_layout" type="zope.schema.Text"
       form:omitted="z3c.form.interfaces.IForm:true
                     z3c.form.interfaces.IAddForm:true
                     z3c.form.interfaces.IEditForm:true">
    <description i18n:translate=""
      >The layout to be used to render groups and tiles</description>
    <title i18n:translate="">Cover Layout</title>
</field>

as it can be seen, this field should be omitted on z3c.form.interfaces.IAddForm but that's not happening and I don't know why.

it's important to note that this happens only while running tests; the field is normally hidden when accessing the add form in a browser.

IMO this field must be redefined as readonly instead of being hidden all over the place.

@hvelarde hvelarde added the bug label Oct 19, 2017
@hvelarde hvelarde self-assigned this Oct 19, 2017
@hvelarde
Copy link
Member Author

@davisagli @datakurre @mauritsvanrees any hints here on why this is happening?

@datakurre
Copy link
Contributor

Would you be able to check if it works with earlier plone.autoform versions?

@idgserpro
Copy link
Member

@datakurre you can check the problem from a plone.app.testing perspective in plone/plone.app.testing#39.

@hvelarde
Copy link
Member Author

hvelarde commented Oct 19, 2017

@datakurre I already did that with no luck; Plone 4.3.12 was using plone.autoform = 1.6.2 also and we saw the error there.

I also tried pinning z3c.form = 3.2.9 with no luck neither.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants