Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Id ranges in JSON files #384

Closed
DandelionSprout opened this issue Aug 23, 2018 · 2 comments
Closed

support Id ranges in JSON files #384

DandelionSprout opened this issue Aug 23, 2018 · 2 comments
Labels
directory-data changes to basic FilterLists data question user question wontfix will not be worked on

Comments

@DandelionSprout
Copy link
Contributor

DandelionSprout commented Aug 23, 2018

For the purposes of saving small bits of time and space when dealing with FilterListMaintainer.json, FilterListLanguage.json and FilterListTag.json, would it be possible to add support for number ranges in ID values?

So that instead of writing (in this example):

  {
    "filterListId": 356,
    "tagId": 9
  },
  {
    "filterListId": 357,
    "tagId": 9
  },
  {
    "filterListId": 358,
    "tagId": 9
  },
  {
    "filterListId": 359,
    "tagId": 9
  },

...it could be written as:

  {
    "filterListId": 356-359,
    "tagId": 9
  },

I have no real idea if it's even possible to do so in a JSON file, however.

@collinbarrett
Copy link
Owner

Hmm... It could be possible, but I think it may take more work than it's worth. And, as it stands now, the json is a replicated model of the RDBMS used in the production application. This feature would de-normalize the data to some extent...

But, will think on it for a bit.

@collinbarrett collinbarrett changed the title Add support for number ranges in JSON files support Id ranges in JSON files Aug 23, 2018
@collinbarrett collinbarrett added the directory-data changes to basic FilterLists data label Aug 23, 2018
@collinbarrett
Copy link
Owner

While I certainly see the desire, I think focusing more on something like a #372 is a better use of our time, and would obsolete these changes.

Thanks for the suggestion, though.

@collinbarrett collinbarrett added the wontfix will not be worked on label Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
directory-data changes to basic FilterLists data question user question wontfix will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants