src/Schema/ChangeStreamValueCaptureType.php (1)

23-29: LGTM: Well-defined enum for change stream value capture types.

The ChangeStreamValueCaptureType enum is well-structured and covers the main types of value capture for change streams. The use of string backing is appropriate for this use case.

Consider adding a brief PHPDoc comment above the enum to describe its purpose and potentially link to relevant documentation. For example:

/**
 * Represents the different types of value capture for change streams in Spanner.
 *
 * @see https://cloud.google.com/spanner/docs/change-streams
 */
enum ChangeStreamValueCaptureType: string
{
    // ... (existing cases)
}

This addition would enhance the self-documentation of the code and provide a quick reference for developers.

src/Schema/ChangeStreamDefinition.php (1)

25-41: Consider improving type safety for the $tables property.

The class documentation is comprehensive and follows PHPDoc standards. However, to enhance type safety, consider using a more specific type hint for the $tables property in the class-level PHPDoc.

Update the class-level PHPDoc to include:

+ * @property array<string, list<string>> $tables

This change will provide better type information for IDEs and static analysis tools.

src/Schema/Blueprint.php (2)

391-395: Consider revising the return type of dropChangeStream.

The dropChangeStream method is implemented correctly and follows the same pattern as the other change stream methods. However, returning a ChangeStreamDefinition object when dropping a change stream might not be the most appropriate approach.

Consider changing the return type to Fluent or void, which would be more consistent with the action of dropping a change stream.

Here's a suggested implementation:

-public function dropChangeStream(string $name): ChangeStreamDefinition
+public function dropChangeStream(string $name): Fluent
 {
-    $this->commands[] = $command = new ChangeStreamDefinition(__FUNCTION__, $name);
-    return $command;
+    return $this->addCommand(__FUNCTION__, ['change_stream' => $name]);
 }

This change would make dropChangeStream consistent with other "drop" methods in the class, such as dropSequence.

---

371-395: Consider adding documentation for the new change stream methods.

The new methods for managing change streams (createChangeStream, alterChangeStream, and dropChangeStream) have been implemented well and are consistent with the existing code style. To improve the usability of these new features, consider adding PHPDoc comments for each method. These comments should include:

1. A brief description of what the method does
2. @param descriptions for the $name parameter
3. @return descriptions
4. @throws information if applicable
5. A link to relevant Spanner documentation about change streams

This additional documentation will help users understand how to use these new methods effectively.

src/Schema/Grammar.php (1)

315-317: Avoid assignments within conditional expressions for better readability

In the formatChangeStreamTables method, there's an assignment within the if condition at line 315:

if ($columnsAsString = $this->columnize($columns)) {
    $string .= "({$columnsAsString})";
}

While valid in PHP, assignments within conditionals can reduce code readability and may lead to unintended bugs. It's clearer to separate the assignment from the condition.

Consider refactoring the code as follows:

+ $columnsAsString = $this->columnize($columns);
- if ($columnsAsString = $this->columnize($columns)) {
+ if (!empty($columnsAsString)) {
    $string .= "({$columnsAsString})";
}

Configuration used: CodeRabbit UI
Review profile: CHILL

CHANGELOG.md (1)

Line range hint 3-8: LGTM with suggestions for clarity

The changelog for v8.3.0 accurately reflects the major changes, including the addition of change stream support as outlined in the PR objectives. However, I have a couple of suggestions to enhance clarity:

1. The entry "add support for snapshot queries (feat: Support snapshot queries #215)" is a significant feature addition. Consider providing a brief explanation of what snapshot queries are and their benefits, as this feature wasn't mentioned in the PR objectives.

2. For the entry "Commit options can now be set through config or through Connection::setCommitOptions(...)", it would be helpful to briefly mention what kinds of commit options can be set and how this enhances functionality.

These additions would provide more context for users reading the changelog.

Configuration used: CodeRabbit UI
Review profile: CHILL

README.md (2)

330-330: Consider using setext-style heading for consistency.

The heading "Change Streams" is using atx-style (with #) while other headings in the document use setext-style (with === or ---). Consider changing it to maintain consistency with the rest of the document.

-### Change Streams
+Change Streams
+---------------

🧰 Tools

🪛 Markdownlint

330-330: Expected: setext; Actual: atx
Heading style

(MD003, heading-style)

---

330-350: LGTM! Consider adding a brief explanation of Change Streams.

The new Change Streams section provides clear and concise information on how to use this feature with the schema builder. The code example effectively demonstrates the creation, alteration, and dropping of change streams.

To enhance this section further, consider adding a brief explanation of what Change Streams are used for and their benefits. This would provide more context for users who might be unfamiliar with the concept.

Here's a suggested addition to the beginning of the section:

Change Streams allow you to capture and process data changes in real-time, enabling various use cases such as replication, auditing, and event-driven architectures. With Laravel Spanner, you can easily manage Change Streams using the schema builder.

🧰 Tools

🪛 Markdownlint

330-330: Expected: setext; Actual: atx
Heading style

(MD003, heading-style)

Configuration used: CodeRabbit UI
Review profile: CHILL

tests/Schema/BlueprintTest.php (6)

532-550: LGTM! Well-structured test for creating a change stream for specific tables.

The test effectively covers:

1. Generating a unique name for the change stream.
2. Creating a change stream for multiple tables.
3. Asserting the correct SQL command is generated.
4. Cleaning up by dropping the change stream after the test.

Consider adding an assertion to verify the change stream's presence in the information schema, similar to the previous test. This would ensure the change stream is actually created in the database.

---

552-568: LGTM! Effective test for creating a change stream for specific table columns.

The test covers key aspects:

1. Generating a unique name for the change stream.
2. Creating a change stream for specific columns of a table.
3. Asserting the correct SQL command is generated.
4. Cleaning up by dropping the change stream after the test.

Consider the following improvements:

1. Add an assertion to verify the change stream's presence in the information schema.
2. Use beforeApplicationDestroyed for cleanup to ensure it runs even if the test fails.

---

570-607: LGTM! Comprehensive test for creating a change stream with various options.

The test effectively covers:

1. Creating a new table and a change stream for that table.
2. Setting multiple options for the change stream (retention period, value capture type, exclusions).
3. Asserting the correct SQL commands for both table and change stream creation.
4. Cleaning up by dropping the change stream after the test.

Consider these enhancements:

1. Add assertions to verify the change stream's presence and options in the information schema.
2. Use beforeApplicationDestroyed for cleanup to ensure it runs even if the test fails.
3. Consider dropping the created table as part of the cleanup process.

---

609-637: LGTM! Well-structured test for altering an existing change stream.

The test effectively covers:

1. Creating a new table and an initial change stream.
2. Altering the change stream with new options.
3. Asserting the correct SQL command for altering the change stream.
4. Cleaning up by dropping the change stream after the test.

Consider these improvements:

1. Add an assertion to verify the altered change stream options in the information schema.
2. Use beforeApplicationDestroyed for cleanup to ensure it runs even if the test fails.
3. Consider dropping the created table as part of the cleanup process.
4. Add a test case for altering multiple options simultaneously to ensure they're all applied correctly.

---

639-660: LGTM! Effective test for dropping a change stream.

The test covers key aspects:

1. Creating a new table and a change stream.
2. Dropping the change stream.
3. Asserting the correct SQL command for dropping the change stream.

Consider these enhancements:

1. Add an assertion to verify that the change stream is actually dropped from the information schema.
2. Add cleanup for the created table to avoid leaving test artifacts in the database.
3. Consider using try-finally or beforeApplicationDestroyed to ensure cleanup runs even if the test fails.

---

517-660: Overall, excellent test coverage for change stream operations.

The new tests comprehensively cover change stream functionality, including creation for all tables, specific tables, and columns, as well as altering and dropping change streams. The tests are well-structured and use unique identifiers to avoid conflicts.

To further enhance the test suite, consider:

1. Implementing a common setup and teardown method for change stream tests to reduce code duplication.
2. Consistently using beforeApplicationDestroyed for cleanup in all tests.
3. Adding assertions to verify actual database state changes in addition to SQL command checks.
4. Creating a helper method for generating unique names to ensure consistency across tests.

Configuration used: CodeRabbit UI
Review profile: CHILL