This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
"Enable Notifications" and "Summarize Notifications" state is lost when exiting the application #72
Labels
bug
Something isn't working
Describe the bug
In the "Active Deals" screen, the state of "Enable Notifications" and "Summarize Notifications" checkboxes is lost when exiting the application. When opening the app, it is always set to "Enable Notifications" checked and "Summarize Notifications" unchecked.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The application should remember the state of "Enable Notifications" and "Summarize Notifications", even after restarting the application. I assume most users (including myself) expect these settings to be remembered, especially when they want to disable notifications.
Desktop :
1.0.0
Additional context
I browsed the code and found out these 2 settings are saved in the 3commas slice, which is not saved on disk and hence re initialized at each startup. I see there is another slice, config that is saved on disk and seem more appropriate. I propose to move the settings from 3commas slice to config slice. I think that the settings should be independant of the profile: it could be confusing for a user with multiple profiles to see the state of the checkbox change depending on the profile.
I'm interested in taking care of this issue, if that's good for you !
The text was updated successfully, but these errors were encountered: