Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSP] TaskFinish is never sent #1035

Closed
srdo opened this issue Dec 5, 2020 · 0 comments · Fixed by #1536
Closed

[BSP] TaskFinish is never sent #1035

srdo opened this issue Dec 5, 2020 · 0 comments · Fixed by #1536
Milestone

Comments

@srdo
Copy link
Contributor

srdo commented Dec 5, 2020

We have started sending TaskStart here https://github.com/lihaoyi/mill/blob/master/bsp/src/mill/bsp/Utils.scala#L32.

The associated TaskFinish should be getting sent from here https://github.com/lihaoyi/mill/blob/master/bsp/src/mill/bsp/BspLoggedReporter.scala#L133

It seems like printSummary is not invoked in many cases, leaving tasks unfinished from the IDE's point of view.

To reproduce check out master, build with ci/publish-local.sh, copy the generated file to your Mill download directory, update .mill-version to mill-release, open Mill with Intellij and press the build button. The build will complete, but lots of tasks in the build overview will appear to still be running.

I've attached a screenshot of what this looks like.
Screenshot from 2020-12-05 13-09-16

@lefou lefou mentioned this issue Oct 23, 2021
@lefou lefou linked a pull request Oct 23, 2021 that will close this issue
@lefou lefou added this to the after 0.10.0-M3 milestone Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants