Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-Build is ignored by GenIdea #2633

Closed
lefou opened this issue Jun 26, 2023 · 3 comments · Fixed by #2638
Closed

Meta-Build is ignored by GenIdea #2633

lefou opened this issue Jun 26, 2023 · 3 comments · Fixed by #2638
Milestone

Comments

@lefou
Copy link
Member

lefou commented Jun 26, 2023

The generated Idea project does not have the necessary source directories under mill-build/src.

@lihaoyi
Copy link
Member

lihaoyi commented Jun 26, 2023

GenIdea doesn't go through the proper bootstrap process, the same way that the mill.bsp.BSP logic does in State.scala. It's probably missing a bunch of stuff as a result.

The proper fix would be to make GenIdea go through the proper bootstrap process as well. This might necessitate moving it from mill.scalalib.GenIdea to mill.runner.GenIdea, so it can properly access the mill.runner.MillBuildBootstrap logic that we use for BSP.

Ideally we would be able to share most of the logic between GenIdea and BSP. They're both just dumping classpaths and source folders after all. But it would take some work to merge the divergent implementations

@lefou
Copy link
Member Author

lefou commented Jun 26, 2023

A new module is probably the better option, as it not really part of the runner but some IDE integration. We could make it a contrib, but that's kind-of degrading its support.

@lefou
Copy link
Member Author

lefou commented Aug 21, 2023

Meta-builds now work and code-navigation works even better now than before, where we relied on IntelliJ Ammonite support. If you get asked by IntelliJ IDEA whether you want to enable Ammonite script support for build.sc and friends, you can safely say "no".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants