You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dep has a lot of fields, most of which are optional, but together it makes the serialized JSON impossible to skim. We should add some special casing to make the serialized form match the code string-literal form in the common case. e.g. instead of
We can preserve the existing verbose serialization for cases that fall outside the common case, but in most cases we should be able to get by with the short serialized form
The text was updated successfully, but these errors were encountered:
I'd really love, if we could avoid to embed the corsier.Dependency class in our Dep class, once we can break compatibility. Beside the JSON representation which gets easier this way, we can fix other issues as well, e.g. the handling of excludes (since exclusions it's deprecated in coursier.Dependency in favor to minimizedExcludes which is a large data structure instead of high level meta data). It also brings us more close to an coursier-free API (#2071), where all coursier related stuff can live in workers.
Since I'm personally thinking of experimenting with alternative dependency resolvers, having a coursier free API in Mill would make it easier to drop-in alternatives, for whatever reasons.
Regarding the serialized format: Most typical dependency setups can be easily represented org:name:version with appended ; separated key=value pairs. And some other settings from coursier.Dependency are even unsupported for Maven-dependencies and likely untested in Mill. It's better to model explicitly what we support and convert to coursier when needed.
Dep
has a lot of fields, most of which are optional, but together it makes the serialized JSON impossible to skim. We should add some special casing to make the serialized form match the code string-literal form in the common case. e.g. instead ofWe should serialize as
"com.lihaoyi:mill-dist:0.12.0-M0-42-581840-DIRTY17588c08"
We can preserve the existing verbose serialization for cases that fall outside the common case, but in most cases we should be able to get by with the short serialized form
The text was updated successfully, but these errors were encountered: