Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MillServerMain and TestRunner kill themselves when a new process starts using the folder #524

Closed
lihaoyi opened this issue Dec 27, 2018 · 1 comment
Milestone

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Dec 27, 2018

Currently, both of these processes have a tendency to runaway, leaving a bunch of test runners or mill servers spinning in the background eating up CPU and battery on your laptop.

While robustifying the Ctrl-C killing logic would be nice, another thing we could do is make them periodically check a PID file to see if they are still the only ones running in a folder, and if not then kill themselves. This is currently what .runBackground does, which seems to work well enough, and it would mean that a runaway process would only survive until the next mill ... command before dying.

@lihaoyi
Copy link
Member Author

lihaoyi commented Aug 19, 2024

Fixed in #3370

@lihaoyi lihaoyi closed this as completed Aug 19, 2024
@lefou lefou added this to the 0.12.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants