Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win test fix #1469

Merged
merged 22 commits into from
Sep 14, 2021
Merged

win test fix #1469

merged 22 commits into from
Sep 14, 2021

Conversation

lefou
Copy link
Member

@lefou lefou commented Sep 13, 2021

  • Fixed more tests for Windows
  • Fix path comparissions in various test
  • CI include more Windows tests
  • Fixed and reworked Proguard module to make CI tests work on Windows
  • Add Proguard.java9RtJar target to make runtime classes available to proguard tool.
  • Scoverage: switched instance cache with classloader cache to fix for Win
  • Run contrib.__.prepareOffline to avoid coursier concurrency issues
  • Some version bumps in tool chain
  • Cleanup

The only contrib test not working is currently Scoverage. Looks like the reader of source files does not properly closes the files resources, so that subseqent test invocations (which try to delete and rebuild a test workspace) can't remove these files on Windows (because of the specific file locking behavior).

@lefou lefou merged commit 8af5676 into com-lihaoyi:main Sep 14, 2021
@lefou lefou added this to the 0.10.0-M2 milestone Sep 14, 2021
@lefou lefou deleted the win-test-fix branch September 14, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant