GenIdea: Improved Scala 3 Support #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # scalalib/src/GenIdeaImpl.scala
|
@informarte I hopefully improved the situation this time. |
lefou
commented
Sep 24, 2021
Comment on lines
+313
to
+318
| .flatMap(y => | ||
| y._2.map { | ||
| case (path, 0) => path -> y._1 | ||
| case (path, idx) => path -> s"${y._1} (${idx})" | ||
| } | ||
| ) |
There was a problem hiding this comment.
Leaving out the index for the first element fixed failing tests on WIndows, where for unknown reasons we always ended up with a scala-library-2.13.6.jar (0).
lefou
commented
Sep 24, 2021
scalalib/src/GenIdeaImpl.scala
Outdated
Comment on lines
462
to
470
| case _ if compilerCp.iterator.isEmpty => None | ||
| case _ if name.startsWith("scala3-library_3-3.0.") => Some("Scala_3_0") | ||
| case _ if name.startsWith("scala-library-2.13.") => Some("Scala_2_13") | ||
| case _ if name.startsWith("scala-library-2.12.") => Some("Scala_2_12") | ||
| case _ if name.startsWith("scala-library-2.11.") => Some("Scala_2_11") | ||
| case _ if name.startsWith("scala-library-2.10.") => Some("Scala_2_10") | ||
| case _ if name.startsWith("scala-library-2.9.") => Some("Scala_2_9") | ||
| case _ if name.startsWith("dotty-version-0.27") => Some("Scala_0_27") | ||
| case _ => None |
There was a problem hiding this comment.
Decided to hardcode the mapping, as Scala 3 support in IJ is still in development and it's a bit unclear if we settle with the current mapping or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
language-levelproperty for Scala library in IntelliJ IDEA.