Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalapblib: support scalajs by default #1488

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Conversation

atty303
Copy link
Contributor

@atty303 atty303 commented Sep 22, 2021

ScalaJS can be supported if gRPC is not used.

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@lefou lefou merged commit 4f91313 into com-lihaoyi:main Sep 23, 2021
@lefou lefou added this to the after 0.10.0-M2 milestone Sep 23, 2021
@atty303 atty303 deleted the scalapblib-js branch September 26, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants