Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up refactor of importTree in RunScript #1749

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Follow up refactor of importTree in RunScript #1749

merged 1 commit into from
Feb 22, 2022

Conversation

lolgab
Copy link
Member

@lolgab lolgab commented Feb 22, 2022

  • Remove extra comma in Evaluator toString

@lolgab
Follow up refactor of importTree in RunScript
b53bc90 
- Remove extra comma in Evaluator toString
lefou
lefou approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@lolgab lolgab marked this pull request as ready for review February 22, 2022 08:54
@lefou lefou merged commit 4dcea91 into com-lihaoyi:main Feb 22, 2022
@lefou lefou added this to the after 0.10.0 milestone Feb 22, 2022
@lolgab lolgab deleted the refactor-import-tree branch February 22, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lolgab @lefou