-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganized and reworked integration tests #1831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Jawn tests to not run under Java 11.
It worked before with Scala 2.12.44, but this specific version isn't working anymore with newer zinc versions. And the build won't work with older or newer version.
lefou
changed the title
WIP: rework integration tests
Reorganized and reworked integration tests
Apr 10, 2022
lolgab
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests are now organized as follows:
Forked tests now no longer require a mill binary installed outside of mill. Instead, some new targets internally create a deployment and use this for the tests.
Run these tests with:
Since zinc 1.6.0, compilation with the specific scala 2.12.4 version is almost unusable. Unfortunately, the version of PlayJson we previously build in the thirdparty integration tests no longer works. I tried to adapt it for older or newer versions but in the end, completely removed this project and repo.
If anybody wants to contribute other projects, e.g. some Scala 3 projects, to our integration test suite, then please go ahead and open a pull request.