Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganized and reworked integration tests #1831

Merged
merged 20 commits into from
Apr 11, 2022
Merged

Conversation

lefou
Copy link
Member

@lefou lefou commented Apr 8, 2022

The integration tests are now organized as follows:

integration/            # integration tests for mill
├── forked              # in a forked process (more realistic)
├── local               # from the running process (faster)
└── thirdparty          # tests building some thirdparty projects with mill
    ├── forked          # in a forked process
    └── local           # from the running process (faster)

Forked tests now no longer require a mill binary installed outside of mill. Instead, some new targets internally create a deployment and use this for the tests.

Run these tests with:

mill integration.local
mill integration.forked
mill integration.thirdparty.local
mill integration.thirdparty.forked
mill integration.__.forked                                            # run all forked tests
mill integration.local.test mill.integration.local.LargeProjectTests  # run selective suite

Since zinc 1.6.0, compilation with the specific scala 2.12.4 version is almost unusable. Unfortunately, the version of PlayJson we previously build in the thirdparty integration tests no longer works. I tried to adapt it for older or newer versions but in the end, completely removed this project and repo.

If anybody wants to contribute other projects, e.g. some Scala 3 projects, to our integration test suite, then please go ahead and open a pull request.

@lefou lefou changed the title WIP: rework integration tests Reorganized and reworked integration tests Apr 10, 2022
@lefou lefou marked this pull request as ready for review April 10, 2022 18:57
@lefou lefou requested review from lihaoyi and lolgab April 10, 2022 18:57
@lefou lefou merged commit e7d9027 into com-lihaoyi:main Apr 11, 2022
@lefou lefou deleted the itest-setup-3 branch April 11, 2022 10:33
@lefou lefou added this to the 0.10.3 milestone Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants