Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upickle to 1.6.0 #1837

Merged
merged 7 commits into from
Apr 13, 2022
Merged

Conversation

scala-steward
Copy link
Contributor

Updates com.lihaoyi:upickle from 1.5.0 to 1.6.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (1.5.0).
You might want to review and update them manually.

docs/antora/modules/ROOT/pages/Plugin_Twirl.adoc
Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.lihaoyi", artifactId = "upickle" } ]

labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1

@lefou lefou requested a review from lihaoyi April 12, 2022 06:36
@lefou
Copy link
Member

lefou commented Apr 12, 2022

Thanks Haoyi! Looks good to me. Although I wonder, whether this change means, that other mill plugins (build against Mill 0.10.0) may also fail to load with newer 0.10.3+ versions? Is this solely a compile-time issue, which is no longer relevant, once built?

@lihaoyi
Copy link
Member

lihaoyi commented Apr 12, 2022

@lefou I think this may be a compile-time-only issue, since the only thing being removed is the def XXX = macro YYY. Presumably if you've already compiled, you'll already have the expanded code doing what the macro was previously doing, and things should work without issue.

@lefou
Copy link
Member

lefou commented Apr 13, 2022

Thanks to upickles binary backward compatibility since 1.4.0, this should be safe.

@lefou lefou merged commit c23511e into com-lihaoyi:main Apr 13, 2022
@lefou lefou added this to the after 0.10.3 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants