Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix Scala.js Modules example #1955

Merged
merged 1 commit into from
Jul 18, 2022
Merged

docs: Fix Scala.js Modules example #1955

merged 1 commit into from
Jul 18, 2022

Conversation

nightscape
Copy link
Contributor

@nightscape nightscape commented Jul 17, 2022 •
edited
Loading

Without this line one gets multiple errors, e.g.

value ivy is not a member of StringContext

lefou
lefou approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me. Thank you!

@lefou lefou merged commit ff20b5a into com-lihaoyi:main Jul 18, 2022
@lefou lefou added this to the after 0.10.5 milestone Jul 18, 2022
@nightscape nightscape deleted the patch-1 branch July 18, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.6
Development

Successfully merging this pull request may close these issues.
2 participants
@nightscape @lefou