From 75322513ac05806370cea2d1a6ffe9493956fccb Mon Sep 17 00:00:00 2001 From: Lorenzo Gabriele Date: Wed, 31 Jul 2024 12:34:12 +0200 Subject: [PATCH 1/2] Add info log when passing args to run on ScalaJSModule --- scalajslib/src/mill/scalajslib/ScalaJSModule.scala | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scalajslib/src/mill/scalajslib/ScalaJSModule.scala b/scalajslib/src/mill/scalajslib/ScalaJSModule.scala index f609c3d110e..de51fbbe079 100644 --- a/scalajslib/src/mill/scalajslib/ScalaJSModule.scala +++ b/scalajslib/src/mill/scalajslib/ScalaJSModule.scala @@ -146,6 +146,9 @@ trait ScalaJSModule extends scalalib.ScalaModule { outer => override def runLocal(args: Task[Args] = T.task(Args())): Command[Unit] = T.command { run(args) } override def run(args: Task[Args] = T.task(Args())): Command[Unit] = T.command { + if (args().value.nonEmpty) { + T.log.info("Passing command line arguments to run is not supported by Scala.js.") + } finalMainClassOpt() match { case Left(err) => Result.Failure(err) case Right(_) => From f55067c7181a771efcabea7a7a749e74a27a3ab4 Mon Sep 17 00:00:00 2001 From: Lorenzo Gabriele Date: Thu, 1 Aug 2024 13:27:46 +0200 Subject: [PATCH 2/2] Change log level to error --- scalajslib/src/mill/scalajslib/ScalaJSModule.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scalajslib/src/mill/scalajslib/ScalaJSModule.scala b/scalajslib/src/mill/scalajslib/ScalaJSModule.scala index de51fbbe079..ae9ff0e7a15 100644 --- a/scalajslib/src/mill/scalajslib/ScalaJSModule.scala +++ b/scalajslib/src/mill/scalajslib/ScalaJSModule.scala @@ -147,7 +147,7 @@ trait ScalaJSModule extends scalalib.ScalaModule { outer => override def run(args: Task[Args] = T.task(Args())): Command[Unit] = T.command { if (args().value.nonEmpty) { - T.log.info("Passing command line arguments to run is not supported by Scala.js.") + T.log.error("Passing command line arguments to run is not supported by Scala.js.") } finalMainClassOpt() match { case Left(err) => Result.Failure(err)