Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error log when passing args to run on ScalaJSModule #3327

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Add error log when passing args to run on ScalaJSModule #3327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7532251
Add info log when passing args to run on ScalaJSModule
lolgab Jul 31, 2024
f55067c
Change log level to error
lolgab Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scalajslib/src/mill/scalajslib/ScalaJSModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ trait ScalaJSModule extends scalalib.ScalaModule { outer =>
override def runLocal(args: Task[Args] = T.task(Args())): Command[Unit] = T.command { run(args) }

override def run(args: Task[Args] = T.task(Args())): Command[Unit] = T.command {
if (args().value.nonEmpty) {
T.log.error("Passing command line arguments to run is not supported by Scala.js.")
}
finalMainClassOpt() match {
case Left(err) => Result.Failure(err)
case Right(_) =>
Expand Down