Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back ??? in sys.props calls #3414

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Put back ??? in sys.props calls #3414

merged 1 commit into from
Aug 23, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Aug 23, 2024

sys.props("doesntexist") returns null instead of throwing like I expected, so this change ensures any misconfiguration resulting in missing environment variables throws

@lihaoyi lihaoyi requested a review from lefou August 23, 2024 09:59
@lihaoyi lihaoyi merged commit 690b9ec into com-lihaoyi:main Aug 23, 2024
31 checks passed
@lefou lefou added this to the 0.12.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants