Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify integration test layout #3457

Merged
merged 24 commits into from
Sep 4, 2024
Merged

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Sep 4, 2024

  • test/src/ just becomes src/, cutting out one unnecessary degree of nesting
  • repo/ is now resources/, letting us use the now-standard MILL_TEST_RESOURCE_FOLDER environment variable rather than the bespoke MILL_INTEGRATION_REPO_ROOT
  • example.foo[bar] no longer extends JavaModule, and instead only defines the minimal set of properties necessary to configure the child local/fork/server modules correctly, and unlike the integration.* modules they do not need to compile anything themselves.
  • The child ModeModules in both example and integration also no longer inherit MillJavaModule, since they do not compile anything themselves. Instead they inherit mill.scalalib.TestModule with the minimal set of properties wired up

This should greatly simplify things overall, as the various integration and example test modules no longer have a bunch of unwanted JavaModule/ScalaModule tasks that need to be overriden.

@lihaoyi lihaoyi marked this pull request as ready for review September 4, 2024 04:04
@lihaoyi lihaoyi added this to the 0.12.0-RC1 milestone Sep 4, 2024
@lihaoyi lihaoyi merged commit 028abe4 into com-lihaoyi:main Sep 4, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant