-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify integration test layout #3457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/src/
just becomessrc/
, cutting out one unnecessary degree of nestingrepo/
is nowresources/
, letting us use the now-standardMILL_TEST_RESOURCE_FOLDER
environment variable rather than the bespokeMILL_INTEGRATION_REPO_ROOT
example.foo[bar]
no longer extendsJavaModule
, and instead only defines the minimal set of properties necessary to configure the childlocal
/fork
/server
modules correctly, and unlike theintegration.*
modules they do not need to compile anything themselves.ModeModule
s in bothexample
andintegration
also no longer inheritMillJavaModule
, since they do not compile anything themselves. Instead they inheritmill.scalalib.TestModule
with the minimal set of properties wired upThis should greatly simplify things overall, as the various integration and example test modules no longer have a bunch of unwanted
JavaModule
/ScalaModule
tasks that need to be overriden.