Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary subfolder wrappers for integration tests #3458

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Sep 4, 2024

Since #3347 made all test suites run with pwd in the test's .dest folder by default, we are already guaranteed that different concurrent test suites will not collide, so we do not need the out/blah/blah segments to avoid conflicts

@lihaoyi lihaoyi marked this pull request as ready for review September 4, 2024 09:38
@lihaoyi lihaoyi merged commit 4caadfb into com-lihaoyi:main Sep 5, 2024
32 of 33 checks passed
@lefou lefou added this to the 0.12.0-RC1 milestone Sep 5, 2024
@lefou
Copy link
Member

lefou commented Sep 5, 2024

Does that mean, we can't no longer inspect the out files of multiple (failed) tests?

@lihaoyi
Copy link
Member Author

lihaoyi commented Sep 5, 2024

Yes. But previously they were all in out/<random-number> folders, so trying to find the output of a particular test was impossible anyway from my experience. We can definitely try to add more logic to assign each test a unique folder

@lefou
Copy link
Member

lefou commented Sep 5, 2024

I never experienced those random number paths, this was probably after your test suite refactoring. I thought, we still had long sub-paths resembling the full test name.

@lihaoyi
Copy link
Member Author

lihaoyi commented Sep 5, 2024

yeah the test suite refactor moved a bunch of hardcoded paths to os.temp. Made the code a lot cleaner, but at a cost of filesystem tidyness. Can probably add them back depending on sourcecode.FullName and utest.framework.TestPath to get the tidyness without the boilerplate

@lefou
Copy link
Member

lefou commented Sep 5, 2024

That sounds reasonable. Both generic sources (FullName as well as TestPath) already provide meaningful names. Paired with a random number, there should only one or a low count of test output directories to inspect, when in need. In LambdaTest, my Java library to write functional tests on top of JUnit/TestNG, I have a autoclosable test path provider, that can clean up automatically on success, but keeps the temp content when failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants