Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle Plugin Cleanup #3520

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Sep 12, 2024

  • Set check = true and stdout = true by default since that's what I'm guessing people will expect
  • Extract out def checkstyleHandleErrors and def checkstyle0 for re-use between CheckstyleModule and CheckstyleXsltModule. This allows def checkstyle to throw errors and report to console while still generating the XSLT reports in CheckstyleXsltModule
  • Avoid reporting no violations when exit code is zero, because there may still be warnings
  • Integrate the example test from @m50d's checkstyle PR Add Checkstyle plugin #3472, flesh it out, and integrate it into the docsite

@lihaoyi lihaoyi merged commit 2e5b649 into com-lihaoyi:main Sep 12, 2024
23 checks passed
@lefou lefou added this to the 0.12.0 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants