Integrate kotlin example into docs #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
reviewed
Sep 15, 2024
Comment on lines
+33
to
+37
| * **Mill follows Gradle's conciseness**: Rather than pages and pages of verbose XML, every | ||
| line in a Mill build is meaningful. e.g. adding a dependency is 1 line in | ||
| Mill, like it is in Gradle, and unlike the 5 line `<dependency>` declaration you find in Maven. | ||
| Skimming and understanding a 100-line Mill `build.mill` file is | ||
| often much easier than skimming the equivalent 500-line Maven `pom.xml`. |
There was a problem hiding this comment.
This section seems to be a bit off. It mostly makes points against Maven, but not Gradle, since Gradle does not use XML and pom.xml files.
Comment on lines
+30
to
+32
| Mill's Kotlin support originated as the third-party plugin | ||
| https://github.com/lefou/mill-kotlin[lefou/mill-kotlin], which was later included with | ||
| the main Mill codebase. |
There was a problem hiding this comment.
Since it differs from Mills own license, here is probably the best place to mention the original license, Apache License 2.0 and provide a link to the license text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kotlin_Intro_to_Mill.adoc,Kotlin_Installation_IDE_Support.adoc,Kotlin_Builtin_Commands.adocpages