docs: glossary infra #34231
Merged
docs: glossary infra #34231
+117
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adeebshihadeh In the original PR, you requested that I revert this change (see comment). I made that adjustment to prevent the Docs CI from failing and to keep the build process simple. The alternatives would be either adding steps to use Python 3.11+ (which includes tomllib by default) or relying on a third-party package, though the latter isn’t my preferred approach. Please provide some insight on how to proceed. |
|
Oh, that's fine then. I thought |
No problem, It seems the rollout started on December 5th and they plan on it being completed by Jan 17th. Source |
adeebshihadeh
requested changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #34155 and splits the work needed for the glossary infra. This PR intention is to only set-up the infrastructure.
Remaining work:
glossary.mddocs: sets glossary.md to automatically load toml definitions #34234Once This PR and the term file gets merged the modified
glossary.mdshould be good to go. Will leave it in draft until the other 2 Prs are mergedCloses #33117