Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethinking Theming support #1661

Open
emmenko opened this issue Nov 9, 2020 · 2 comments
Open

Rethinking Theming support #1661

emmenko opened this issue Nov 9, 2020 · 2 comments
Assignees
@ddouglasz @kark @CarlosCortizasCT
Labels
🌗 good rotation topic Good to rotate a member into Application Kit to work on this topic 💡 Type: Idea Propose a new idea 🏕 Type: Technical Exploration Try out a new library or approach

Comments

@emmenko
Copy link
Member

emmenko commented Nov 9, 2020

We should also probably rethink a bit how we plan and want to continue support theming.
At the moment is more of a "hidden" feature but we do rely on it in other places.
It's also not super consistent as only a bunch of components support that.

Apparently, in some recent emotion updates there have been some "regressions" (#1660 and commercetools/commercetools-docs-kit#745) which forces us to fix that here.

I think we need to make a decision how we want to continue the theming support.

PS: have a read at https://epicreact.dev/css-variables/ as an inspiration for an alternative approach (assuming it would be possible in our setup).
@bradd123
Copy link
Contributor

bradd123 commented Mar 1, 2021

Has any discussion happened regarding this?

@tdeekens
Copy link
Contributor

tdeekens commented Mar 1, 2021

Nope. It hasn't been a priority and we do not need it ourselves at the moment.

@emmenko emmenko added 🌗 good rotation topic Good to rotate a member into Application Kit to work on this topic 🏕 Type: Technical Exploration Try out a new library or approach 💡 Type: Idea Propose a new idea labels Apr 9, 2021
@kark kark mentioned this issue Jul 11, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddouglasz ddouglasz

@kark kark

@CarlosCortizasCT CarlosCortizasCT

Labels
🌗 good rotation topic Good to rotate a member into Application Kit to work on this topic 💡 Type: Idea Propose a new idea 🏕 Type: Technical Exploration Try out a new library or approach
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@emmenko @tdeekens @bradd123 @ddouglasz @kark @CarlosCortizasCT