PAT-590 incorrect docker image content #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the user executes `stack image container --image image9` where the stack.yaml has multiple docker image definitions. The code was staging all of them but then creating an image by selecting the base image (correct) along with the contents of folder "0" (incorrect) Solution is to only stage the image(s) that we want to build (using the same image name fitering that we have in our function to build the image(s). Haskell does not protect you from logic fails :D
|
LGTM |
borsboom
deleted the
PAT-590-stack-image-container-with-image-option-does-not-behave-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the user executes
stack image container --image image9where the stack.yaml has multiple docker image definitions. The code
was staging all of them but then creating an image by selecting the base
image (correct) along with the contents of folder "0" (incorrect)
Solution is to only stage the image(s) that we want to build (using the
same image name fitering that we have in our function to build the
image(s).
Haskell does not protect you from logic fails :D