-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make snapshot: a synonym for resolver: #4256
Comments
Also: update Does stack have any philosophy regarding deprecation? Should support for |
We don't have an official policy. In the past, we've:
|
Hi, guys! |
Yes to both questions! The best place to start would be to grep the |
Guys, I'm sorry for the delay |
No worries, thanks for the update. |
@snoyberg can you tell me if I'm thinking in the right direction? I want to add stack/src/Stack/Types/Config.hs Line 1452 in cf9b94d
My plan is:
For now I'm thinking of how to write the tests: If that is a correct line of thought then I have a question:
How can I do something like
in a test? |
Overall that sounds right. I'm not quite sure what "temp predefined stack.yaml" means. For the unit test, you're going to have to construct a |
I was trying to say that I will copy workflow of
Thx for your help, it was useful! |
Closed by #4341 |
I discussed this already on Twitter. Basic idea: resolver turns out to have not been a great name. That field is used for specifying a snapshot. Let's just call a spade a spade.
Implementation: in both snapshots and stack.yaml files, instead of looking for just
resolver
, we'll look for bothresolver
andsnapshot
. If both are present: it's an error. If one is present, use it. If neither are present, follow through with current behavior for when there's no resolver set.The text was updated successfully, but these errors were encountered: