Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubts about the presentation of an error #4370

Closed
danse opened this issue Oct 23, 2018 · 10 comments
Closed

Doubts about the presentation of an error #4370

danse opened this issue Oct 23, 2018 · 10 comments

Comments

@danse
Copy link

danse commented Oct 23, 2018

A few times in the past i met the following error while using Stack:

installed package <a> is broken due to missing package <b>

The last time the specific error was:

installed package haddock-library-1.5.0.1 is broken due to missing package haddock-library-1.5.0.1-919WkNWGnku6Kvc4vlhbv1-attoparsec

Which has already been described in #4071. Here i am asking about the generic error, because i feel like it refers to something that i didn't learn reading the Stack documentation. Maybe it's obvious, or maybe if other people turn to have similar doubts we could think about expanding the doc or rephrasing the error.

So, package a is broken because package b is missing. Missing from where? From the resolver? Is there anything i can do, or should i rather change the resolver? The broken packages must be rebuilt ... after i changed the resolver? If i want to understand the error better do i want to look on Stack, Cabal or GHC? Or do we want people to open issues on the tracker for package a when this error happens?

@dbaynard
Copy link
Contributor

dbaynard commented Mar 3, 2019

@danse What commands did you use, which resulted in that error? It would be helpful to see the detail asked for in the issue template.

@danse
Copy link
Author

danse commented Mar 4, 2019

thanks for following up @dbaynard. The error occurred in multiple cases when trying to build different projects. Originally i wanted to track up the point in the code where the error is formed, in order to understand the semantics it is referring to. If you want we can investigate together :)

@dbaynard
Copy link
Contributor

dbaynard commented Mar 4, 2019

Well, let's focus on a reproduction. Which stack version were you using? Then, can you reproduce it once (while running with --verbose) and then paste the logs?

@danse
Copy link
Author

danse commented Mar 4, 2019

Oh, i fixed this problem several times, i'm not blocked on an instance of it at the moment. Often when i have been blocked on this, it turned out to be some fundamental error or some error that could be fixed with the help of package maintainers. So this is not a current issue to me, i just opened it with the speculative intent of improving the presentation of similar errors. If you prefer to consider only current issues and are collecting design conversations elsewhere, we can close this one

@dbaynard
Copy link
Contributor

dbaynard commented Mar 4, 2019

Let's keep this going, here, then. The issue you linked concerned stack's implementation of internal libraries, which has now been fixed, hence some of my confusion. I'm all for improving how stack handles this situation but I don't quite understand what that situation is.

So, package a is broken because package b is missing. Missing from where? From the resolver? Is there anything i can do, or should i rather change the resolver? The broken packages must be rebuilt ... after i changed the resolver? If i want to understand the error better do i want to look on Stack, Cabal or GHC? Or do we want people to open issues on the tracker for package a when this error happens?

In this situation, stack should build package b. Unfortunately without a concrete reproduction, I can't work out the answers to any of your questions…

@danse
Copy link
Author

danse commented Mar 5, 2019

So understanding the problem and improving the phrasing at a generic level seems more demanding than i had expected. The lack of a reference to a failing test case makes it harder to spot the cause and i cannot find the error text message with a text search in the code. I think that this issue is not very helpful at the moment, it can be closed. If anyone will stumble upon the problem in the future, they could find this issue and reopen the conversation with a concrete case at hand. Thanks for your support! ✌️

@dbaynard
Copy link
Contributor

dbaynard commented Mar 5, 2019

i cannot find the error text message with a text search in the code.

Ah, I should have said this, earlier. I believe the error comes from Cabal, but I haven't checked the source either.

OK, let's close for now, and if it reappears we can reopen. Thanks for taking the time to report this, though. And if you'd like to help make contributions then I may be able to find something you'll enjoy working on!

@danse
Copy link
Author

danse commented Mar 6, 2019

Ah, I should have said this, earlier. I believe the error comes from Cabal

oh, your comment led me to the line where the error is defined, which is informative. It seems like this message is shown to users when Graph.broken fullIndex is true, and that is a great clue in order to think of a clearer phrasing. So you are right, this is about Cabal and in order to progress we want to create a new issue there. This will stay here for future reference.

I may be able to find something you'll enjoy working on

thanks for the offer! contributing to stack feels a bit daunting, and challenging this feeling would be fun! i prefer to start from ideas that pop up while using the tool though, so i guess that i will be back to this issue tracker soon! :)

@dbaynard
Copy link
Contributor

dbaynard commented Mar 6, 2019

Thanks for pointing out the specific source of the error in Cabal. Cabal is not responsible for dependencies, though, so I would hesitate to suggest a change there (but if you can think of an improvement, go right ahead).

Stack has volunteers who triage issues (aiming to get to them sooner than we did with you — thank you for your patience!). We're looking for more people to get involved, so if that appeals let one of us know. There are also issues marked 'help wanted' and 'newcomer friendly'. Whatever you decide, I look forward to it!

@danse
Copy link
Author

danse commented Mar 28, 2019

Stack has volunteers who triage issues (aiming to get to them sooner than we did with you — thank you for your patience!). We're looking for more people to get involved, so if that appeals let one of us know. There are also issues marked 'help wanted' and 'newcomer friendly'. Whatever you decide, I look forward to it!

Thanks, i'll keep that in mind! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants