-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(api): add integration tests #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Create the lib/__apis__/ directory 2. Add Jest/Jasmine specs without mocks 3. Invoke real APIs for results GH-18
gregswindle
added
priority: high
Affects consumer retention or product reputation.
status: accepted
The proposal has community consensus
type: breaking change
Modifications affect or replace the public API. ⇧ Bumps the MAJOR semver.
type: docs
Add, edit, or delete instructional material.
type: chore
Changes that don't modify source or test files.
type: refactor
Restructuring source code without changing its external behavior.
type: fix
Defect repairs. ⇧ Bumps the PATCH semver.
type: test
Adding, correcting, or improving tests (coverage).
labels
Apr 18, 2018
BREAKING CHANGE: two method signatures and one property name have changed. **Objects & Properties** 1. readmeInspector.ReadmeScore - refactor:rename ReadmeScore ➡️ ReadmeAppraisal 2. module:readme-inspector/readme-score - refactor:rename 'ReadmeScore' module:readme-inspector/readme-appraisal 'ReadmeAppraisal', which is now a class. **Functions** 1. getReadmeInfo 1.1. Function name - refactor:rename ➡️ getInfo 1.2. Function signature - now expects a params object literal 2. getReadmeScore 2.1. Function name - refactor:rename ➡️ getAppraisal 2.2. Function signature remains the same as in 1.x.x. 3. check's signature now expects a params object literal, which it passes to getInfo. **API tests** Add API (integration) tests. GH-18,GH-21
gregswindle
modified the milestones:
Bitbucket repo README inspection (v1.1.0),
Fix ReadmeScore
Apr 21, 2018
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gregswindle
removed
the
help wanted
Contributions welcome or extra attention needed.
label
May 2, 2018
gregswindle
removed
status: available
Voluntary contributions welcome ♥!
status: review needed
Needs community inspection or approval.
labels
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority: high
Affects consumer retention or product reputation.
status: accepted
The proposal has community consensus
type: breaking change
Modifications affect or replace the public API. ⇧ Bumps the MAJOR semver.
type: chore
Changes that don't modify source or test files.
type: docs
Add, edit, or delete instructional material.
type: fix
Defect repairs. ⇧ Bumps the PATCH semver.
type: refactor
Restructuring source code without changing its external behavior.
type: test
Adding, correcting, or improving tests (coverage).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request (PR)
lib/__apis__/
directoryAssociated issue(s)
Closes #18
Souce code analysis
Code quality summary
Code quality, vulnerability, and standards compliance tools
How to format, lint, and test your changes
Open a Terminal, go to the root directory for
readme-inspector
, and run:$ npm test