Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json does not list devDependencies #142

Closed
LynnKirby opened this issue Jun 8, 2018 · 2 comments
Closed

package.json does not list devDependencies #142

LynnKirby opened this issue Jun 8, 2018 · 2 comments

Comments

@LynnKirby
Copy link
Contributor

LynnKirby commented Jun 8, 2018

The packages used during development should be included in package.json. Many are listed in the readme or installed via make. The project should conform to the standard development route of using a single npm install to setup the environment.

@jgm
Copy link
Member

jgm commented Jun 8, 2018 via email

@LynnKirby
Copy link
Contributor Author

That's what devDependencies are for. They don't get installed unless you npm install from the package root (e.g. as a developer working on it) or if the consumer of the package opts in with a CLI flag.

@jgm jgm closed this as completed in #145 Jun 8, 2018
jgm pushed a commit that referenced this issue Jun 8, 2018
* Use local development dependencies

Packages used during development are now listed in devDependencies of
package.json. Makefiles are updated to use those local versions.
References to manually installing packages are removed from README.md
and bench/bench.js. The package-lock.json file used in newer NPM
versions is also added.

Fixes: #142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants