Bug fix for root template and Cluster reference #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnPreston
added a commit
that referenced
this pull request
May 3, 2020
* Bug fix for root template and Cluster reference (#20) * Expand TagsSpecifications with x-tags (#24) * Reformatted with black (#25) * Allow to specify directory to write all the templates to in addition to S3. (#27) * Added `make conform` to run black against the code to standardize syntax (#26) * Templates & Stacks refactor (#38) * Refactor of XModules logic onto ECS services (#39) * x-rds implemented and tested working with Aurora (#29) * Working SQS refactor (#40) * Docs update and first go at IAM perms (#22) * Updated tests and small patches for 0.2.0 (#43) * Added License header and changed to GPLv3 (#44) * Docs for 0.2.0 (#42) Signed-off-by: John Preston <john@lambda-my-aws.io>
JohnPreston
pushed a commit
that referenced
this pull request
May 3, 2020
* Bug fix for root template and Cluster reference (#20) * Expand TagsSpecifications with x-tags (#24) * Reformatted with black (#25) * Allow to specify directory to write all the templates to in addition to S3. (#27) * Added `make conform` to run black against the code to standardize syntax (#26) * Templates & Stacks refactor (#38) * Refactor of XModules logic onto ECS services (#39) * x-rds implemented and tested working with Aurora (#29) * Working SQS refactor (#40) * Docs update and first go at IAM perms (#22) * Updated tests and small patches for 0.2.0 (#43) * Added License header and changed to GPLv3 (#44) * Docs for 0.2.0 (#42) Signed-off-by: John Preston <john@lambda-my-aws.io>
JohnPreston
pushed a commit
that referenced
this pull request
May 3, 2020
* Bug fix for root template and Cluster reference (#20) * Expand TagsSpecifications with x-tags (#24) * Reformatted with black (#25) * Allow to specify directory to write all the templates to in addition to S3. (#27) * Added `make conform` to run black against the code to standardize syntax (#26) * Templates & Stacks refactor (#38) * Refactor of XModules logic onto ECS services (#39) * x-rds implemented and tested working with Aurora (#29) * Working SQS refactor (#40) * Docs update and first go at IAM perms (#22) * Updated tests and small patches for 0.2.0 (#43) * Added License header and changed to GPLv3 (#44) * Docs for 0.2.0 (#42) Signed-off-by: John Preston <john@lambda-my-aws.io>
JohnPreston
pushed a commit
that referenced
this pull request
May 3, 2020
* Bug fix for root template and Cluster reference (#20) * Expand TagsSpecifications with x-tags (#24) * Reformatted with black (#25) * Allow to specify directory to write all the templates to in addition to S3. (#27) * Added `make conform` to run black against the code to standardize syntax (#26) * Templates & Stacks refactor (#38) * Refactor of XModules logic onto ECS services (#39) * x-rds implemented and tested working with Aurora (#29) * Working SQS refactor (#40) * Docs update and first go at IAM perms (#22) * Updated tests and small patches for 0.2.0 (#43) * Added License header and changed to GPLv3 (#44) * Docs for 0.2.0 (#42) Signed-off-by: John Preston <john@lambda-my-aws.io>
JohnPreston
pushed a commit
that referenced
this pull request
May 3, 2020
* Bug fix for root template and Cluster reference (#20) * Expand TagsSpecifications with x-tags (#24) * Reformatted with black (#25) * Allow to specify directory to write all the templates to in addition to S3. (#27) * Added `make conform` to run black against the code to standardize syntax (#26) * Templates & Stacks refactor (#38) * Refactor of XModules logic onto ECS services (#39) * x-rds implemented and tested working with Aurora (#29) * Working SQS refactor (#40) * Docs update and first go at IAM perms (#22) * Updated tests and small patches for 0.2.0 (#43) * Added License header and changed to GPLv3 (#44) * Docs for 0.2.0 (#42) Signed-off-by: John Preston <john@lambda-my-aws.io>
JohnPreston
added a commit
that referenced
this pull request
May 3, 2020
* Added License header and changed to GPLv3 (#44) * Bug fix for root template and Cluster reference (#20) * Expand TagsSpecifications with x-tags (#24) * Reformatted with black (#25) * Allow to specify directory to write all the templates to in addition to S3. (#27) * Added `make conform` to run black against the code to standardize syntax (#26) * Templates & Stacks refactor (#38) * Refactor of XModules logic onto ECS services (#39) * x-rds implemented and tested working with Aurora (#29) * Working SQS refactor (#40) * Docs update and first go at IAM perms (#22) * Updated tests and small patches for 0.2.1 (#43) * Added License header and changed to GPLv3 (#44) * Docs for 0.2.1 (#42) *Patch CLI and CFN tool to generate the CFN configuration file. Signed-off-by: John Preston <john@lambda-my-aws.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed logic to be simplier:
In case we are not creating the cluster, we simply !Ref to the EcsClusterName
Else we create the cluster and !Ref to the EcsCluster object to get the ClusterName for onwards stacks.