Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix code quality tests #129

Closed
computablee opened this issue Dec 6, 2023 · 0 comments · Fixed by #137
Closed

[CI] Fix code quality tests #129

computablee opened this issue Dec 6, 2023 · 0 comments · Fixed by #137
Assignees
@computablee
Labels
CI/CD Deals with the GitHub CI/CD pipelines refactor Refactor or restructure code to better align with good engineering practices
Milestone
DotMP v2.0 Checklist

Comments

@computablee
Copy link
Owner

Currently, code quality is failing. This is due to the jscpd detector, and fails in GPUTests.cs and Buffer.cs. This should be fixed to tidy up the checks.
@computablee computablee added refactor Refactor or restructure code to better align with good engineering practices CI/CD Deals with the GitHub CI/CD pipelines labels Dec 6, 2023
@computablee computablee self-assigned this Dec 6, 2023
@computablee computablee added this to the DotMP v2.0 Checklist milestone Dec 7, 2023
@computablee computablee mentioned this issue Dec 20, 2023
Merged
@computablee computablee linked a pull request Dec 20, 2023 that will close this issue
Fix code quality tests #137
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@computablee computablee

Labels
CI/CD Deals with the GitHub CI/CD pipelines refactor Refactor or restructure code to better align with good engineering practices
Projects
None yet
Milestone
DotMP v2.0 Checklist
Development

Successfully merging a pull request may close this issue.

Fix code quality tests computablee/DotMP
1 participant
@computablee