refactor + optimize release contributor and draft release logic #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
performance improvements for Contributor queries - fix n+1 select in Codebase.compute_contributors - clear the Codebase contributors cache in redis instead of re-computing the cache after creating or updating ReleaseContributors on a given CodebaseRelease. The cache should be lazily regenerated on the next view. - remove dead code Codebase.objects.compute_contributors which is no longer used / needed
except in cases where `id` overrides the builtin `id` function ruff check django --fix
None or '' does not trigger the default filter unless we set the second parameter to true https://jinja.palletsprojects.com/en/3.1.x/templates/#jinja-filters.default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff check django --fixand dependency updates