Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run precommit checks in CI #68

Open
asmacdo opened this issue Jun 10, 2024 · 2 comments
Open

Run precommit checks in CI #68

asmacdo opened this issue Jun 10, 2024 · 2 comments
Assignees

Comments

@asmacdo
Copy link
Member

asmacdo commented Jun 10, 2024

From @yarikoptic #57 (review)

Since you have it in pre-commit -- could have a pre-commit CI to check all of them if so was desired.
here is a number of projects calling to pre-commit in their workflows -- didn't check yet for best example

here is a number of projects calling to pre-commit in their workflows -- didn't check yet for best example
❯ grep -l pre-commit */.github/workflows/*
aiohttp_retry/.github/workflows/python-package.yml
asv/.github/workflows/pre-commit.yml
belay/.github/workflows/pre-commit.yaml
black/.github/workflows/lint.yml
boto3/.github/workflows/lint.yml
briefcase/.github/workflows/ci.yml
briefcase/.github/workflows/pre-commit-update.yml
celery/.github/workflows/linter.yml
cibuildwheel/.github/workflows/test.yml
codecarbon/.github/workflows/pre-commit.yml
commitizen/.github/workflows/pythonpackage.yml
django-rest-framework/.github/workflows/pre-commit.yml
filesystem_spec/.github/workflows/main.yaml
gpt-engineer/.github/workflows/pre-commit.yaml
home-assistant/.github/workflows/ci.yaml
lark/.github/workflows/mypy.yml
lazy_loader/.github/workflows/lint.yml
mamba/.github/workflows/linters.yml
mdformat/.github/workflows/tests.yaml
mlflow/.github/workflows/autoformat.yml
mlflow/.github/workflows/lint.yml
mlflow/.github/workflows/recipe-template.yml
mypy/.github/workflows/test.yml
networkx/.github/workflows/lint.yml
nilearn/.github/workflows/update_precommit_hooks.yml
ome-zarr-py/.github/workflows/precommit.yml
pixi/.github/workflows/pre-commit.yml
prefect/.github/workflows/static-analysis.yaml
pydantic/.github/workflows/ci.yml
pydantic/.github/workflows/docs-update.yml
pyparsing/.github/workflows/pre-commit.yml
python-cookiecutter/.github/workflows/test.yml
requests/.github/workflows/lint.yml
ruff/.github/workflows/ci.yaml
ruff/.github/workflows/release.yaml
singularity-hpc/.github/workflows/main.yml
yarl/.github/workflows/reusable-linters.yml
zarr-python/.github/workflows/needs_release_notes.yml
@asmacdo
Copy link
Member Author

asmacdo commented Aug 8, 2024

See #57 (comment)

@yarikoptic
Copy link
Member

I might be slow but how that comment relates if in pre-commit we do not check README ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants