Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package] opentelemetry-cpp/1.8.1: SHORT DESCRIPTION #14832

Closed
rbharvs opened this issue Dec 20, 2022 · 1 comment · Fixed by #14834
Closed

[package] opentelemetry-cpp/1.8.1: SHORT DESCRIPTION #14832

rbharvs opened this issue Dec 20, 2022 · 1 comment · Fixed by #14834
Labels
bug Something isn't working

Comments

@rbharvs
Copy link

rbharvs commented Dec 20, 2022

Description

When installing on my M1 Macbook Pro, the recipe errs with the following message:

opentelemetry-cpp/1.8.1: Invalid ID: opentelemetry-cpp/1.8.1 doesn't support architecture : armv8

This is simply due to a hard-coded check in the Conan recipe. However, according to the opentelemetry-cpp project, "ARM architecture is supported by otel-cpp, so hardcoding could be removed from Conan package."

See the issue I filed with opentelemetry-cpp: open-telemetry/opentelemetry-cpp#1874

Package and Environment Details

  • Package Name/Version: opentelemetry-cpp/1.8.1
  • Operating System+version: MacOS 12.4 (arm64-apple-darwin21.5.0)
  • Compiler+version: clang-1316.0.21.2.5
  • Conan version: conan 1.53.0
  • Python version: Python 3.10.6

Conan profile

[settings]
os=Macos
os_build=Macos
arch=armv8
arch_build=armv8
compiler=apple-clang
compiler.version=13
compiler.libcxx=libc++
build_type=Release
[options]
[conf]
[build_requires]
[env]

Steps to reproduce

We have Conan integrated into our CMake build, so the command I ran was cmake ..

Logs

Click to expand log
-- Conan: Automatic detection of conan settings from cmake
-- Conan: compiler.cppstd was added as an argument. Not using the autodetected one.
-- Conan: Settings= -s;build_type=Debug;-s;compiler=apple-clang;-s;compiler.version=13.1;-s;compiler.libcxx=libc++;-s;compiler.cppstd=20
-- Conan: checking conan executable
-- Conan: Found program /Users/myuser/.pyenv/shims/conan
-- Conan: Version found Conan version 1.53.0
-- Conan executing: /Users/myuser/.pyenv/shims/conan install /Users/myuser/Documents/datamodel-server/conanfile.txt -s build_type=Debug -s compiler=apple-clang -s compiler.version=13.1 -s compiler.libcxx=libc++ -s compiler.cppstd=20 -g=cmake --build=missing
Configuration:
[settings]
arch=armv8
arch_build=armv8
build_type=Debug
compiler=apple-clang
compiler.cppstd=20
compiler.libcxx=libc++
compiler.version=13.1
os=Macos
os_build=Macos
[options]
[build_requires]
[env]

WARN: grpc/1.47.1: requirement openssl/1.1.1q overridden by your conanfile to openssl/1.1.1s
WARN: grpc/1.47.1: requirement zlib/1.2.12 overridden by your conanfile to zlib/1.2.13
WARN: protobuf/3.21.4: requirement zlib/1.2.12 overridden by grpc/1.47.1 to zlib/1.2.13
WARN: libpq/14.2: requirement openssl/1.1.1q overridden by libpqxx/7.7.4 to openssl/1.1.1s
WARN: opentelemetry-cpp/1.8.1: requirement abseil/20220623.0 overridden by your conanfile to abseil/20211102.0
WARN: opentelemetry-cpp/1.8.1: requirement grpc/1.50.1 overridden by your conanfile to grpc/1.47.1
WARN: opentelemetry-cpp/1.8.1: requirement nlohmann_json/3.11.2 overridden by your conanfile to nlohmann_json/3.10.5
WARN: thrift/0.17.0: requirement openssl/1.1.1q overridden by opentelemetry-cpp/1.8.1 to openssl/1.1.1s
pkgconf/1.9.3: WARN: Package binary is corrupted, removing: cb188579dd91605256b76b89243f76e7b4276240
conanfile.txt: Installing package
Requirements
    abseil/20211102.0 from 'conancenter' - Cache
    boost/1.80.0 from 'conancenter' - Cache
    bzip2/1.0.8 from 'conancenter' - Cache
    c-ares/1.18.1 from 'conancenter' - Cache
    fmt/8.1.1 from 'conancenter' - Cache
    googleapis/cci.20220711 from 'conancenter' - Cache
    grpc/1.47.1 from 'conancenter' - Cache
    grpc-proto/cci.20220627 from 'conancenter' - Cache
    libbacktrace/cci.20210118 from 'conancenter' - Cache
    libcurl/7.86.0 from 'conancenter' - Cache
    libevent/2.1.12 from 'conancenter' - Cache
    libiconv/1.17 from 'conancenter' - Cache
    libpq/14.2 from 'conancenter' - Cache
    libpqxx/7.7.4 from 'conancenter' - Cache
    nlohmann_json/3.10.5 from 'conancenter' - Cache
    openssl/1.1.1s from 'conancenter' - Cache
    opentelemetry-cpp/1.8.1 from 'conancenter' - Cache
    opentelemetry-proto/0.19.0 from 'conancenter' - Cache
    protobuf/3.21.4 from 'conancenter' - Cache
    re2/20220601 from 'conancenter' - Cache
    spdlog/1.10.0 from 'conancenter' - Cache
    thrift/0.17.0 from 'conancenter' - Cache
    zlib/1.2.13 from 'conancenter' - Cache
Packages
    abseil/20211102.0:91b82a353802d494cb97a7c89382a2bcffa387c5 - Cache
    boost/1.80.0:a5831fd0ec686b5de1fb414bf9effd528106a64b - Build
    bzip2/1.0.8:6a8f360aed14aff13d8ddb3a32e1ac042a72a395 - Build
    c-ares/1.18.1:261f6d76ecab46766353f900b5703cf660254b81 - Cache
    fmt/8.1.1:bed8608787d3e1c1d64a57429ac22b6b78e473c5 - Cache
    googleapis/cci.20220711:1591322bd42fd2c51c09c175c2efa0c1b9122c87 - Cache
    grpc/1.47.1:fdeb3a3350a2b4faf3739d2b0cfe78319f70a76b - Cache
    grpc-proto/cci.20220627:000cc12059629128470c5004d522877ca7584862 - Cache
    libbacktrace/cci.20210118:6124f2723e498ba98ee9b85ff813e81aa399a58b - Build
    libcurl/7.86.0:5e2bc76ff83bb4268e5a3239c4cdda99d7a751dd - Build
    libevent/2.1.12:b9a1964e8214ee655938b2363dbddfeab94ec7d2 - Build
    libiconv/1.17:6124f2723e498ba98ee9b85ff813e81aa399a58b - Build
    libpq/14.2:b9a1964e8214ee655938b2363dbddfeab94ec7d2 - Cache
    libpqxx/7.7.4:cacf4939c5122784023dc7c1e7096eb5eb06d657 - Cache
    nlohmann_json/3.10.5:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Cache
    openssl/1.1.1s:6124f2723e498ba98ee9b85ff813e81aa399a58b - Cache
    opentelemetry-cpp/1.8.1:INVALID - Invalid
    opentelemetry-proto/0.19.0:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Download
    protobuf/3.21.4:f4fea1ac84ad1521e42295079ef8926e9ab8e8a0 - Cache
    re2/20220601:91b82a353802d494cb97a7c89382a2bcffa387c5 - Cache
    spdlog/1.10.0:9b6b541cfcfc9933b5ef3d3917272fa0aa0845ef - Cache
    thrift/0.17.0:3887583eebcc87fba7fbb91375e70b56ffe05186 - Build
    zlib/1.2.13:6124f2723e498ba98ee9b85ff813e81aa399a58b - Build
Build requirements
    autoconf/2.71 from 'conancenter' - Cache
    automake/1.16.5 from 'conancenter' - Cache
    b2/4.9.2 from 'conancenter' - Cache
    bison/3.7.6 from 'conancenter' - Cache
    flex/2.6.4 from 'conancenter' - Cache
    gnu-config/cci.20210814 from 'conancenter' - Cache
    libtool/2.4.7 from 'conancenter' - Cache
    m4/1.4.19 from 'conancenter' - Cache
    meson/0.62.1 from 'conancenter' - Cache
    ninja/1.11.1 from 'conancenter' - Cache
    pkgconf/1.9.3 from 'conancenter' - Cache
Build requirements packages
    autoconf/2.71:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Cache
    automake/1.16.5:3c28ba69276b46fd46e9c2060ba991d725ccab43 - Cache
    b2/4.9.2:a5ad5696abf650a25eea8f377806b3d5fe234e6e - Download
    bison/3.7.6:037e9539fbe58cb4231884023c5abe710248e2e3 - Build
    flex/2.6.4:037e9539fbe58cb4231884023c5abe710248e2e3 - Build
    gnu-config/cci.20210814:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Cache
    libtool/2.4.7:69205973a4aedcabd642a42caac278b389f17eff - Build
    m4/1.4.19:cb188579dd91605256b76b89243f76e7b4276240 - Cache
    meson/0.62.1:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Cache
    ninja/1.11.1:cb188579dd91605256b76b89243f76e7b4276240 - Cache
    pkgconf/1.9.3:cb188579dd91605256b76b89243f76e7b4276240 - Build

Installing (downloading, building) binaries...
ERROR: There are invalid packages (packages that cannot exist for this configuration):
opentelemetry-cpp/1.8.1: Invalid ID: opentelemetry-cpp/1.8.1 doesn't support architecture : armv8
CMake Error at submodules/datamodel-library/datamodel/conan.cmake:529 (message):
  Conan install failed='6'
Call Stack (most recent call first):
  submodules/datamodel-library/datamodel/conan.cmake:766 (old_conan_cmake_install)
  CMakeLists.txt:33 (conan_cmake_run)


-- Configuring incomplete, errors occurred!
See also "/Users/myuser/Documents/datamodel-server/build/CMakeFiles/CMakeOutput.log".
See also "/Users/myuser/Documents/datamodel-server/build/CMakeFiles/CMakeError.log".
@rbharvs rbharvs added the bug Something isn't working label Dec 20, 2022
@toge
Copy link
Contributor

toge commented Dec 20, 2022

@rbharvs
Thanks for the report.
The logic to exclude non-x86_64 from support seems to have been specified around 1.0.1. 6d68936#diff-c07065fa17a58e51c2b83e0810c72267d76083f4011ce96af2edbf99cde3419bR42-R44

As far as I can see from the issue you shared, it appears that ARM is officially supported, so I fixed the logic.

I do not have any ARM environments, so please let me check if CI works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants