[bug] dbus: generated dbus-1.pc incorrectly has Requires: xorg

[tsondergaard]

Environment details

When building qt with with_dbus=True and dbus option with_x11=True I see a dbus-1.pc like this being generated:

$ cat ./p/b/qt1f8e4c91c1b89/b/dbus-1.pc
prefix=/home/ts/.conan2/p/b/dbuse119f1e6f4a56/p
libdir=${prefix}/lib
includedir=${prefix}/include
includedir1=${prefix}/include/dbus-1.0
includedir2=${prefix}/lib/dbus-1.0/include
bindir=${prefix}/bin

Name: dbus-1
Description: Conan package: dbus-1
Version: 1.15.8
Libs: -L"${libdir}" -ldbus-1 -lrt -lpthread
Cflags: -I"${includedir}" -I"${includedir1}" -I"${includedir2}"
Requires: expat xorg

It incorrectly lists xorg as dependency, which is incorrect. When dbus is built with with_x11 the libdbus-1 library is not affected - the only impact is that a binary dbus-launch is built that depends on x11.

• Operating System+version: AlmaLinux 9.3
• Compiler+version: gcc (GCC) 11.4.1 20230605 (Red Hat 11.4.1-2)
• Conan version: 2.0.16
• Python version: 3.9.18

Steps to reproduce

No response

Logs

No response

[memsharded]

Hi @tsondergaard

Thanks for your report.

I am not sure this is a Conan client issue. I see the ConanCenter recipe contains in

conan-center-index/recipes/dbus/1.x.x/conanfile.py

Line 78 in f4eb09a

self.requires("xorg/system")

self.requires("xorg/system")

There are no components definition or anything similar, so the recipe depends on xorg and that results in the definition of that requires in .pc files, so looks correct. If we would like something different that would be implemented adding components to the dbus recipe, though I am not sure it is really worth.

I am moving this ticket to ConanCenter github repo, but please note that at the moment there is a huge queue of open PRs to ConanCenter, so this might take a while to be addressed.