DevIL: add new recipe #25720

n-morales · 2024-10-25T18:30:02Z

Summary

Changes to recipe: devil/1.8.0

Motivation

DevIL (Developer's Image Library) is an open source image loading library https://github.com/DentonW/DevIL

Details

Adds the devil library version 1.8.0

Read the contributing guidelines
Checked that this PR is not a duplicate: list of PRs by recipe
Tested locally with at least one configuration using a recent version of Conan

CLAassistant · 2024-10-25T18:30:08Z

All committers have signed the CLA.

n-morales · 2024-10-25T18:32:01Z

Do I still need to include a v1 tester?

…abled

AbrilRBS · 2024-10-28T21:11:57Z

Hi @n-morales thanks a lot for taking the time to add this recipe, we appreciate it. I've submited some changes to your branch, feel free to take a look. They resolve the compilation issues we were seeing on static builds, and add lcms support, as the upstream cmakelists is looking for it and we would have to explicitly disable it otherwise.

I've removed the LIB set from the generate function, which afaik had no effect and Conan was already handling correctly on its own. Let me know if you see anything else, happy to help :)

AbrilRBS · 2024-10-28T21:34:16Z

recipes/devil/all/conandata.yml

+    - "https://github.com/DentonW/DevIL/archive/refs/tags/v1.8.0.tar.gz"
+    sha256: "52129f247b26fcb5554643c9e6bbee75c4b9717735fdbf3c6ebff08cee38ad37"
+patches:
+  "1.8.0":


Do you have any extra insight as to where these patches come from? Thanks!

patches/1.8.0-jp2_fix.patch is similar to other fixes I found while searching for this issue including:
https://github.com/DentonW/DevIL/pull/102/files
https://gitlab.archlinux.org/archlinux/packaging/packages/devil/-/blob/main/jasper.patch?ref_type=heads

The jpeg fix and the remove register I came up with, but it looks like someone else did the same (for register fix) in https://github.com/DentonW/DevIL/pull/109/files

n-morales · 2024-10-28T23:15:51Z

Hi @n-morales thanks a lot for taking the time to add this recipe, we appreciate it. I've submited some changes to your branch, feel free to take a look. They resolve the compilation issues we were seeing on static builds, and add lcms support, as the upstream cmakelists is looking for it and we would have to explicitly disable it otherwise.

I've removed the LIB set from the generate function, which afaik had no effect and Conan was already handling correctly on its own. Let me know if you see anything else, happy to help :)

Thanks for adjusting it! I don't have a mac os machine to test on so I was relying on the conan ci. It looks like there are some windows issues; I do have access to a windows machine but likely won't have the time to patch until the weekend.

conan-center-bot · 2024-11-01T20:10:38Z

Conan v1 pipeline ❌

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Failure in build 13 (97e3008137d9bb4cd0fc1fa0b69fba9da69ace99):

devil/1.8.0:
CI failed to create some packages (All logs)

Logs for packageID 7f1034e4d2a893003727cdfb35ecd77fa13472b7:

[settings]
arch=armv8
build_type=Debug
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=13.0
os=Macos
[options]
devil:shared=True

[...]
  "_jbg_strerror", referenced from:
      _JBIGDecode in libtiff.a(tif_jbig.c.o)
  "_libdeflate_alloc_compressor", referenced from:
      _ZIPEncode in libtiff.a(tif_zip.c.o)
  "_libdeflate_alloc_decompressor", referenced from:
      _ZIPDecode in libtiff.a(tif_zip.c.o)
  "_libdeflate_free_compressor", referenced from:
      _ZIPVSetField in libtiff.a(tif_zip.c.o)
      _ZIPCleanup in libtiff.a(tif_zip.c.o)
  "_libdeflate_free_decompressor", referenced from:
      _ZIPCleanup in libtiff.a(tif_zip.c.o)
  "_libdeflate_zlib_compress", referenced from:
      _ZIPEncode in libtiff.a(tif_zip.c.o)
  "_libdeflate_zlib_compress_bound", referenced from:
      _ZIPEncode in libtiff.a(tif_zip.c.o)
  "_libdeflate_zlib_decompress", referenced from:
      _ZIPDecode in libtiff.a(tif_zip.c.o)
  "_lzma_code", referenced from:
      _LZMADecode in libtiff.a(tif_lzma.c.o)
      _LZMAPostEncode in libtiff.a(tif_lzma.c.o)
      _LZMAEncode in libtiff.a(tif_lzma.c.o)
  "_lzma_end", referenced from:
      _LZMASetupDecode in libtiff.a(tif_lzma.c.o)
      _LZMASetupEncode in libtiff.a(tif_lzma.c.o)
      _LZMACleanup in libtiff.a(tif_lzma.c.o)
  "_lzma_lzma_preset", referenced from:
      _TIFFInitLZMA in libtiff.a(tif_lzma.c.o)
      _LZMAVSetField in libtiff.a(tif_lzma.c.o)
  "_lzma_memusage", referenced from:
      _LZMADecode in libtiff.a(tif_lzma.c.o)
  "_lzma_stream_decoder", referenced from:
      _LZMAPreDecode in libtiff.a(tif_lzma.c.o)
      _LZMADecode in libtiff.a(tif_lzma.c.o)
  "_lzma_stream_encoder", referenced from:
      _LZMAVSetField in libtiff.a(tif_lzma.c.o)
      _LZMAPreEncode in libtiff.a(tif_lzma.c.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [lib/x64/libIL.dylib] Error 1
make[1]: *** [src-IL/CMakeFiles/IL.dir/all] Error 2
make: *** [all] Error 2
WARN: **************************************************
WARN: *** Conan 1 is legacy and on a deprecation path **
WARN: *********** Please upgrade to Conan 2 ************
WARN: **************************************************
devil/1.8.0: ERROR: Package '7f1034e4d2a893003727cdfb35ecd77fa13472b7' build failed
devil/1.8.0: WARN: Build folder /Users/jenkins/workspace/prod-v1/bsr/116561/accee/.conan/data/devil/1.8.0/_/_/build/7f1034e4d2a893003727cdfb35ecd77fa13472b7/build/Debug
ERROR: devil/1.8.0: Error in build() method, line 99
	cmake.build()
	ConanException: Error 2 while executing cmake --build "/Users/jenkins/workspace/prod-v1/bsr/116561/accee/.conan/data/devil/1.8.0/_/_/build/7f1034e4d2a893003727cdfb35ecd77fa13472b7/build/Debug" '--' '-j8'

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 13 (97e3008137d9bb4cd0fc1fa0b69fba9da69ace99):

devil/1.8.0:
All packages built successfully! (All logs)

AbrilRBS · 2024-11-04T16:52:49Z

I've launched the CI with the new piepeline, let's see how it it goes (results now go into the checks tab of the PR!)

jcar87 · 2024-11-04T17:23:23Z

I've launched the CI with the new piepeline, let's see how it it goes (results now go into the checks tab of the PR!)

mmm this hook warning would need to be addressed:

install_name dir of these shared libs is not @rpath: libIL.dylib, libILU.dylib, libILUT.dylib

(unless they're runtime-loaded plugins or something)

n-morales · 2024-11-09T16:33:31Z

I've launched the CI with the new piepeline, let's see how it it goes (results now go into the checks tab of the PR!)

mmm this hook warning would need to be addressed:
install_name dir of these shared libs is not @rpath: libIL.dylib, libILU.dylib, libILUT.dylib
(unless they're runtime-loaded plugins or something)

I'm not really familiar with mac os development -- how should these be addressed?

add DevIL recipe

be64a05

conan-center-bot added the Failed label Oct 25, 2024