Merge pull request #31 from hollalll726/QuickReply

Raise value error to avoid unknown error in server
conbus · Sep 4, 2017 · d53505f · d53505f
2 parents be4af7e + 0912ca8
commit d53505f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/fbmq/payload.py b/fbmq/payload.py
@@ -40,6 +40,8 @@ class Message(object):
     def __init__(self, text=None, attachment=None, quick_replies=None, metadata=None):
         if text is not None and attachment is not None:
             raise ValueError('Please set only one parameter "text" or "attachment"')
+        if not isinstance(quick_replies, list) and quick_replies is not None:
+            raise ValueError('quick_replies type must be "list"')
 
         self.text = text
         self.attachment = attachment

diff --git a/tests/test_payload.py b/tests/test_payload.py
@@ -28,6 +28,8 @@ def test_receipt(self):
     def test_message(self):
         with self.assertRaises(Exception):
             m = Payload.Message(text="hello", attachment=Attachment.Image('img'))
+        with self.assertRaises(ValueError):
+            m = Payload.Message(text="hello", quick_replies=Payload.QuickReply(title='Yes', payload='PICK_YES'))
 
         m = Payload.Message(text="hello", metadata="METADATA", quick_replies=[{'title': 'Yes', 'payload': 'PICK_YES'}])
         self.assertEquals('{"attachment": null, "metadata": "METADATA", '