Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use content_for :head like other plugins #50

Open
mfrederickson opened this issue Sep 12, 2019 · 0 comments
Open

use content_for :head like other plugins #50

mfrederickson opened this issue Sep 12, 2019 · 0 comments

Comments

@mfrederickson
Copy link
Contributor

This plugin is not consistent with the others in terms of including stuff in the head rather than the body, and is missing its "from" comments.

<html>
  <head>
    <meta charset="UTF-8">
    <title>Concerto - Sample Screen</title>
    <link rel="stylesheet" media="screen" href="/assets/frontend/application.css?body=1" />
<link rel="stylesheet" media="screen" href="/assets/frontend/fields.css?body=1" />
<link rel="stylesheet" media="screen" href="/assets/frontend/screens.css?body=1" />
<link rel="stylesheet" media="screen" href="/assets/frontend/ticker.css?body=1" />
    <script src="/assets/jquery.js?body=1"></script>
<script src="/assets/frontend/screen_setup.js?body=1"></script>
<script src="/assets/frontend/application.js?body=1"></script>
    <meta name="csrf-param" content="authenticity_token" />
<meta name="csrf-token" content="yAXud6OlKkjenFVhch9rb/2+Th60iGP2kz/g0BlCARG5rlNoklEVVP7ivsFdxDYV/2ieZiucy2ctvNnCNb23IQ==" />
    <meta name="apple-mobile-web-app-capable" content="yes"/>
    <meta name="apple-mobile-web-app-status-bar-style" content="black-translucent"/>
    <meta name="format-detection" content="telephone=no"/>
      <!-- from concerto-frontend -->
  <script src="/assets/moment.min.js?body=1"></script>
<script src="/assets/moment-timezone-with-data.min.js?body=1"></script>
<script src="/assets/concerto_frontend/application.js?body=1"></script>

  <!-- end from concerto-frontend -->
<!-- from concerto-remote-video -->
  <link rel="import" href="/assets/concerto_remote_video/concerto-remote-video.html" />
<!-- end from concerto-remote-video -->
<!-- from concerto-iframe -->
  <link rel="import" href="/assets/concerto_iframe/concerto-iframe.html" />
<!-- end from concerto-iframe -->
  </head>
  <body>
    
  <!-- from concerto-frontend -->
  <concerto-screen screen-id="1" preview="true" base-url=""></concerto-screen>
  <!-- end from concerto-frontend -->

<link rel="stylesheet" media="screen" href="/assets/concerto_weather/application.css?body=1" />
<link rel="stylesheet" media="screen" href="/assets/concerto_weather/owfont-regular.css?body=1" />
<link rel="stylesheet" media="screen" href="/assets/concerto_weather/weather-icons.min.css?body=1" />
<link rel="stylesheet" media="screen" href="/assets/concerto_weather/weather-icons-wind.min.css?body=1" />
<link rel="stylesheet" media="screen" href="/assets/concerto_weather/weather.css?body=1" />


    <!-- display a font-awesome icon offscreen so the font is loaded, otherwise it may try to load it on demand when the server is unavailable -->
    <div id="primeFontAwesome" style="display:block; opacity: 0; position: absolute; top: -20px; right: -20px; z-index: -1">
      <i class="fa fa-spinner fa-spin"></i>
    </div>
  </body>
</html>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mfrederickson