Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tinymce dependency issue / Embroider compatibility #182

Closed
ctjhoa opened this issue Dec 6, 2021 · 5 comments
Closed

Tinymce dependency issue / Embroider compatibility #182

ctjhoa opened this issue Dec 6, 2021 · 5 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@ctjhoa
Copy link
Contributor

ctjhoa commented Dec 6, 2021

To support embroider,
We need to change tinymce dependency management as suggested in the following post
miragejs/ember-cli-mirage#1497

Npm equilavent to Yarn resolutions is overrides
https://stackoverflow.com/questions/52416312/npm-equivalent-of-yarn-resolutions
npm/statusboard#343

However implementation is not complete.

Related commit:
349f14a
@ctjhoa
Copy link
Contributor Author

ctjhoa commented Dec 8, 2021 •
edited
Loading

We may want to use https://www.npmjs.com/package/validate-peer-dependencies at some point to use peerDependencies property instead of overrides

@ctjhoa
Copy link
Contributor Author

ctjhoa commented Jan 28, 2022 •
edited
Loading

ember-moment apparently gives tips on that.
https://github.com/adopted-ember-addons/ember-moment#using-momentjs-in-ember-apps--addons

Ember addon V2 ? https://github.com/adopted-ember-addons/ember-moment/blob/master/src/index.js

@ctjhoa
Copy link
Contributor Author

ctjhoa commented Jan 28, 2022

Related meetup https://www.youtube.com/watch?v=5m40BCh3BGk

@ctjhoa ctjhoa changed the title Tinymce dependency issue Tinymce dependency issue / Embroider compatibility Jan 28, 2022
@ctjhoa ctjhoa added bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request and removed enhancement New feature or request labels Jan 28, 2022
@ctjhoa
Copy link
Contributor Author

ctjhoa commented Apr 12, 2022 •
edited
Loading

We can use npm alias to use a private version of tinymce

{
  "dependencies": {
    "tinymce": "npm:@concordnow/tinymce@^5.10.2-127"
  }
}

@ctjhoa ctjhoa mentioned this issue Apr 26, 2022
Open
@ctjhoa ctjhoa mentioned this issue May 5, 2022
Closed
@ctjhoa
Copy link
Contributor Author

ctjhoa commented Oct 13, 2022 •
edited
Loading

Move to addon v2 solve this issue #263

@ctjhoa ctjhoa closed this as completed Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to ember addon v2 concordnow/tinymce-ember
1 participant
@ctjhoa