Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate additional .git/branch file #391

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

britto
Copy link
Contributor

@britto britto commented Sep 28, 2022

It will contain the name of the cloned branch.

Extracted this part from #257 as suggested by @jamieklassen in #257 (review) and by @vito in #198 (comment). I've also added a few tests.

@britto britto force-pushed the add-git-branch-file branch from 9ed303d to 8863434 Compare September 28, 2022 01:45
@xtremerui xtremerui force-pushed the master branch 2 times, most recently from 0e21d41 to 5f77e61 Compare November 17, 2022 04:50
@britto britto force-pushed the add-git-branch-file branch from 8863434 to 32a8c35 Compare November 28, 2022 21:29
@britto britto force-pushed the add-git-branch-file branch from 32a8c35 to ce80a9a Compare December 13, 2022 20:29
@taylorsilva
Copy link
Member

This looks good! Going to try and get CI to run all the tests before merging.

containing the name of the original cloned branch.

Signed-off-by: João Britto <jabcalves@gmail.com>
@taylorsilva taylorsilva force-pushed the add-git-branch-file branch from ce80a9a to 7095560 Compare April 5, 2024 15:18
@taylorsilva
Copy link
Member

I rebased the branch onto master

Copy link
Member

@taylorsilva taylorsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @britto and apologies for having it sit here for over a year! 🙏

@taylorsilva taylorsilva merged commit 702bf5a into concourse:master Apr 5, 2024
2 checks passed
@britto britto deleted the add-git-branch-file branch April 26, 2024 13:19
@britto
Copy link
Contributor Author

britto commented Apr 26, 2024

Thank you, @taylorsilva!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .git/branch as additional populated file Checkout non-detatched mode
2 participants