Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support S3 repositories with multipart upload/download disabled #100

Open
eamonryan opened this issue Apr 27, 2018 · 0 comments
Open

Support S3 repositories with multipart upload/download disabled #100

eamonryan opened this issue Apr 27, 2018 · 0 comments

Comments

@eamonryan
Copy link

I've noticed that the S3 resource does not function when the target S3 server is something other than Amazon and does not have multipart upload/download enabled.

For uploads, I'm currently seeing a behaviour where those work fine and files appear to be uploaded successfully via the s3-resource so that's good and may be related to #92 though that seems to be for 3.9.0 and we are testing against 3.8.0.

For downloads, the behaviour seen is that the download of a file using the s3-resource is marked as succeeded but has only downloaded 5MB of the file and left it truncated. See this screenshot:

screen shot 2018-04-27 at 12 01 18

This obviously causes subsequent pipeline steps to fail.

We found that downloads work fine on files smaller than 5MB as you can see here:
screen shot 2018-04-27 at 12 00 41

Since the default part size is 5MB this sounds suspiciously like it just goes with that default size and since the server does not have multipart enabled and does not send more parts, calls it good and marks it succeeded but you actually end up with a truncated file.

We can download the same files just fine via the s3cli manually, so this does appear to be localised to the s3-resource not handling this server configuration well.

Can we enhance the s3-resource to support this S3 server configuration? At the very least I feel the pipeline should not mark a 5MB truncated file as a successful download and we should note on the s3 resource and any relevant documentation that multipart is a required setting.

However, I've noticed that finding this setting is not always easy with the various S3 software vendors, some requiring patches to add the functionality and so it would be a better solution to just support either configuration if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant