Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opencv as a core dependency package? #335

Closed
dstansby opened this issue Nov 11, 2022 · 2 comments
Closed

Add opencv as a core dependency package? #335

dstansby opened this issue Nov 11, 2022 · 2 comments
Labels

Comments

@dstansby
Copy link

Comment:

I've just been testing https://github.com/conda-forge/sunpy-feedstock, which now depends on opencv for testing. We have run up against the error in this issue: #321.

The conda-forge docs say (https://conda-forge.org/docs/maintainer/adding_pkgs.html#avoid-external-dependencies):

As a general rule: all dependencies have to be packaged by conda-forge as well. This is necessary to assure ABI compatibility for all our packages.
There are only a few exceptions to this rule:
Some dependencies have to be satisfied with CDT packages (see Core Dependency Tree Packages (CDTs)).

From reading the conda-forge docs it seems like opencv should be packaged as a Core Dependency Tree Package, not a normal feedstock package. To avoid the libGL linking error should opencv be added as a Core Dependency Tree package instead of living here as a normal feedstock?

@hmaarrfk
Copy link
Contributor

I think the conversion here #293 is relevant.

@hmaarrfk
Copy link
Contributor

I'm going to close this since I think 293 is the relevant issue. let me know if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants