-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specifying llvm-openmp
only in build leads to a run_exports
against the latest llvm-openmp
#126
Comments
Yeah we had a discussion about the need for IOW an operation that adds a dependency to The original use case involved compiler libraries that need to be statically linked (so must be in This sounds like another case where we need this. Namely we want a tighter coupling between |
What do you mean by this? |
IMO, libgcc-ng run_export is wrong. It should have a run_export. If so, we won't have to have the hack at |
We have an environment where I would like to use the same pinnings as conda-forge, i.e., clang and llvm-openmp are pinned to |
We've hit this now in the R 4.4 migration:
(i.e., (I only got aware of this issue since https://github.com/conda-forge/r-data.table-feedstock/blob/807a816c953af4ddabaa591366f79f38b88d7eb5/recipe/meta.yaml#L36 has it in |
Another case is conda-forge/r-rcpparmadillo-feedstock#72 : Meaning, our |
I think we should have |
Or in both |
Yes, we have to have them in (Apart from cross-compilations) what were the reasons to have them in |
Would it suffice to add |
That should help. |
If a user does not specify
llvm-openmp
inbuild
andhost
but only inbuild
, it will lead to packages that will have a pin ofllvm-openmp >=latest-release
. The pin will be independent of thellvm-openmp
version used inbuild
.This is due to the fact that
conda-build
takes the strongrun_exports
frombuild
and implicitly adds them to thehost
environment, see https://github.com/conda/conda-build/blob/9c0ceec8d96d265e33d960c46024db78f4e3efd8/conda_build/render.py#L451 This then leads to the latest version ofllvm-openmp
being installed intohost
and itsrun_export
taken into account. My guess is that the actual line adding them is https://github.com/conda/conda-build/blob/9c0ceec8d96d265e33d960c46024db78f4e3efd8/conda_build/render.py#L489This is then annoying if you want to build something with the compilers pinned as in conda-forge, but outside a conda-build setting where you only have a single environment.
I'm not sure whether we should correct this on the
conda-build
side or in the feedstock here. For other situations likelibgcc-ng
this is not a problem aslibgcc-ng
itself doesn't have arun_export
.The text was updated successfully, but these errors were encountered: