Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile with C++17 (compatibility with abseil) #61

Closed
h-vetinari opened this issue Feb 15, 2023 · 1 comment · Fixed by #62
Closed

Compile with C++17 (compatibility with abseil) #61

h-vetinari opened this issue Feb 15, 2023 · 1 comment · Fixed by #62

Comments

@h-vetinari
Copy link
Member

I hit a problem in conda-forge/or-tools-feedstock#21, which is that:

cannot convert 'sp' (type 'absl::lts_20220623::string_view*' {aka 'std::basic_string_view<char>*'}) to type 're2::StringPiece*'

The situation is described in more detail in this upstream commit google/re2@6543c37, but I don't think we want to consider building the upstream abseil branch.

The respective header switches on #ifdef __cpp_lib_string_view, so it should work fine once we compile it with C++17.

Note however that this will be an ABI change (intentionally, because as of now re2::StringPiece doesn't match std::string_view, but afterwards it would), so we'll have to figure out how to do this (e.g. we could bump the version from 2023-02-01 to 2023-02-02, but that would mean remigrating everything).

CC @conda-forge/re2

@h-vetinari
Copy link
Member Author

Giving this a shot in #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant