-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impact of new PyPI dependency. #150
Comments
This sounds like we need to maintain a patch on the conda-forge side that removes this entry from the |
If there's indeed no way to declare a specific dependency being "PyPI only", we can probably add a template for generating the toml file based on target environments and run it as part the the packaging steps. |
Currently we are using Normally conda-build disables installing dependencies from As a workaround to the issue previously noted, we typically either set the same environment variables conda-build would or pass equivalent flags to Don't think we will need to do more than that for this case (so no patch hopefully) |
That's good news! I was worrying about how to make specialization. |
Comment:
Hi all,
We want to add
NCCL
as apyproject
dependency to avoid static linking in PyPI binary release: dmlc/xgboost#9796 , this can help us reduce two-thirds of the weight on PyPI. Others (conda-forge, for instance) can continue to link nccl at compile time without any change. (non-breaking for C++)However, we are not sure what would be the potential impact on the conda Python package during installation. After the change, is it still possible for XGBoost on conda-forge to use nccl from conda channels instead of PyPI? It would be great if we don't need to fetch nccl using pip when XGBoost is installed using conda/mamba. (like
pip --no-dependencies
) If not, is there anything we can do to ensure the Python package is compatible with both distribution methods, like adding apyproject
template or inserting predicates somewhere in the build/install process?The text was updated successfully, but these errors were encountered: