-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribute the CMake configuration file. #189
Comments
Thanks Jiaming! 🙏 Agree we should do this Likely we are missing some lines here. Do you know what we need to add? xgboost-feedstock/recipe/install-libxgboost.sh Lines 29 to 32 in 3fe446a
|
I wonder why we don't just use |
Agree that would be preferable Think this has to do with how Windows is setup Maybe there is a good way to accomplish this just with CMake? xgboost-feedstock/recipe/install-libxgboost.sh Lines 3 to 7 in 3fe446a
xgboost-feedstock/recipe/install-libxgboost.sh Lines 9 to 12 in 3fe446a
|
Maybe |
Agree that sounds like a reasonable approach Would you like to give it a try? 🙂 |
It will probably take some time before I can get to it. |
Solution to issue cannot be found in the documentation.
Issue
The C header is distributed along with
libxgboost
, but not the CMake exported configuration files. The feedstock might be able to distribute CMake files as well as done bymake install
target. The downstream users should be able to call:find_package(xgboost)
Installed packages
Environment info
The text was updated successfully, but these errors were encountered: