New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for base prefix to all routes #98

Closed

costrouc opened this issue Jul 27, 2021 · 1 comment · Fixed by #109

Labels

type: enhancement 💅🏼

Milestone

Member

costrouc commented Jul 27, 2021

QHub often deploys services behind a given url prefix so that only one single domain is needed for multiple services. Need to add a prefix argument similar to https://github.com/jupyterhub/jupyterhub/blob/main/jupyterhub/app.py#L617.

This will involve modifications to the app routes along with jinja templates for the ui.

costrouc added the type: enhancement 💅🏼 label

costrouc added this to the Release 0.3.0 milestone

costrouc changed the title ~~Support for prefix to all routes~~ Support for base prefix to all routes

Member Author

costrouc commented Aug 19, 2021

I think this should be possible via https://exploreflask.com/en/latest/blueprints.html#using-a-dynamic-url-prefix. The docker route cannot support the prefix and that is fine.

jaimergp mentioned this issue

add support for url prefixes #109

Merged

costrouc closed this as completed in #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment