Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patchelf regression breaks conda-build #4881

Open
2 tasks done
jacobwilliams opened this issue May 12, 2023 · 4 comments
Open
2 tasks done

Patchelf regression breaks conda-build #4881

jacobwilliams opened this issue May 12, 2023 · 4 comments
Labels
pending::support indicates user is waiting on support from triage engineers source::community catch-all for issues filed by community members stale::recovered [bot] recovered after being marked as stale type::bug describes erroneous operation, use severity::* to classify the type

Comments

@jacobwilliams
Copy link

jacobwilliams commented May 12, 2023

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

FYI: A change or regression in patchelf has broken conda-build on some systems. See here: NixOS/patchelf#492

I think conda-build just pulls the latest patchelf? Would it be better to pin a specific version?

@jacobwilliams jacobwilliams added the type::bug describes erroneous operation, use severity::* to classify the type label May 12, 2023
@travishathaway travishathaway added the source::community catch-all for issues filed by community members label May 15, 2023
@travishathaway
Copy link
Contributor

Hi @jacobwilliams,

Thanks for filing this issue. patchelf is currently not pinned to a specific version. It might be reasonable to begin doing this.

Can you please link to any of the build failures you have encountered so we have a little more background information before making this decision?

@travishathaway travishathaway added the pending::feedback indicates we are waiting on feedback from the user label May 15, 2023
@jacobwilliams
Copy link
Author

jacobwilliams commented May 24, 2023

The builds are not public, so I can't link to them. But, the build works fine. It's building a shared library to be loaded from Python. When Python loads it, we see an error like this:

OSError: /path/blah.so: ELF load command address/offset not properly aligned

Reverting back to patchelf 0.17.2 fixes it for me.

@conda-bot conda-bot added pending::support indicates user is waiting on support from triage engineers and removed pending::feedback indicates we are waiting on feedback from the user labels May 24, 2023
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label May 24, 2024
@jacobwilliams
Copy link
Author

Still a major issue that has not been fixed (conda-build is still pulling the broken patchelf by default).

Auto-closing unfixed "stale" issues is a terrible policy.

@github-actions github-actions bot added stale::recovered [bot] recovered after being marked as stale and removed stale [bot] marked as stale due to inactivity labels May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending::support indicates user is waiting on support from triage engineers source::community catch-all for issues filed by community members stale::recovered [bot] recovered after being marked as stale type::bug describes erroneous operation, use severity::* to classify the type
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants