Improve error message when update fails due to channel conflict #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
maresb
changed the title
| if self.metadata.channels != other.metadata.channels: | ||
| raise ValueError( | ||
| f"Cannot merge locked dependencies when the channels are not " | ||
| f"consisitent. {self.metadata.channels} != {other.metadata.channels}. " |
There was a problem hiding this comment.
Typo "consisitent" -> "consistent"
maresb
force-pushed
the
improve-error-message
branch
from
7a92253 to
49f9eff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #734
Thanks @AndrewPollard for the report! Indeed the previous error message is not so great. Could you please review what I wrote here? Would this have been more clear for you, or do you have an idea for how to make it better?